[GitHub] [spark] cloud-fan commented on a change in pull request #29547: [SPARK-32705][SQL][BugFix] EmptyHashedRelation$; no valid constructor

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #29547:
URL: https://github.com/apache/spark/pull/29547#discussion_r477136045



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
##########
@@ -1066,10 +1074,9 @@ private[joins] object LongHashedRelation {
 
 /**
  * Common trait with dummy implementation for NAAJ special HashedRelation
- * EmptyHashedRelation
  * HashedRelationWithAllNullKeys
  */
-trait NullAwareHashedRelation extends HashedRelation with Externalizable {
+trait NullAwareHashedRelation extends HashedRelation {

Review comment:
       we don't need the trait if it only has one sub-class.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org