[GitHub] [incubator-pekko-http] jrudolph commented on a diff in pull request #34: Rename akka package to org.apache.pekko

["jrudolph (via GitHub)" <gi...@apache.org>]

jrudolph commented on code in PR #34:
URL: https://github.com/apache/incubator-pekko-http/pull/34#discussion_r1105536374


##########
docs/src/main/paradox/handling-blocking-operations-in-pekko-http-routes.md:
##########
@@ -66,7 +66,6 @@ For example, the above screenshot shows an Apache Pekko FJP dispatchers threads,
 named "`default-akka.default-dispatcher2,3,4`" going into the blocking state, after having been idle. 
 It can be observed that the number of new threads increases, "`default-akka.actor.default-dispatcher 18,19,20,...`" 
 however they go to sleep state immediately, thus wasting the resources.
-@java[The same happens to the global @apidoc[ForkJoinPool] when using Java Futures.]

Review Comment:
   Was that deleted intentionally? (Does not matter a lot)



##########
docs/src/test/scala/docs/http/scaladsl/Http2Spec.scala:
##########
@@ -4,31 +4,39 @@
 
 package docs.http.scaladsl
 
-import akka.http.impl.util.ExampleHttpContexts
-import akka.http.scaladsl.model.{ HttpRequest, HttpResponse, StatusCodes }
+import org.apache.pekko
+import pekko.http.impl.util.ExampleHttpContexts
+import pekko.http.scaladsl.model.{ HttpRequest, HttpResponse, StatusCodes }
 
 //#bindAndHandleSecure
 import scala.concurrent.Future
 
-import akka.http.scaladsl.HttpsConnectionContext
 //#bindAndHandleSecure
 
-//#http2ClientWithPriorKnowledge
-//#http2Client
 //#bindAndHandleSecure
 //#bindAndHandlePlain
-import akka.http.scaladsl.Http
+import org.apache.pekko

Review Comment:
   The structure of the imports and how they are referenced into the docs seems to have changed here, was that intended?



##########
http-core/src/main/java/akka/http/javadsl/model/AttributeKeys.java:
##########
@@ -1,18 +0,0 @@
-/*
- * Copyright (C) 2019-2022 Lightbend Inc. <https://www.lightbend.com>
- */
-
-package akka.http.javadsl.model;

Review Comment:
   For a bunch of those files, the changes seem to be big enough that git does not detect the move any more, I guess not a big problem in practice, though.



##########
http-core/src/main/java/akka/http/javadsl/model/AttributeKeys.java:
##########
@@ -1,18 +0,0 @@
-/*
- * Copyright (C) 2019-2022 Lightbend Inc. <https://www.lightbend.com>
- */
-
-package akka.http.javadsl.model;

Review Comment:
   For `git diff` it seems adding the parameter `-M1` works (consider renamed when only 10% of the file are the same, instead of default 50%).
   
   For `git blame` adding `-C` helps to get the original commits.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org