You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "vahmed-hamdy (via GitHub)" <gi...@apache.org> on 2024/01/23 11:21:31 UTC
[PR] [FLINK-31472] Disable Intermittently failing throttling test [flink]
vahmed-hamdy opened a new pull request, #24175:
URL: https://github.com/apache/flink/pull/24175
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
- Disabling intermittently failing test due to high frequency of failures.
## Brief change log
- Added `Disabled` annotation to `AsyncSinkWriterThrottlingTest`
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-31472] Disable Intermittently failing throttling test [flink]
Posted by "vahmed-hamdy (via GitHub)" <gi...@apache.org>.
vahmed-hamdy commented on PR #24175:
URL: https://github.com/apache/flink/pull/24175#issuecomment-1921379510
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-31472] Disable Intermittently failing throttling test [flink]
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on code in PR #24175:
URL: https://github.com/apache/flink/pull/24175#discussion_r1463221597
##########
flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriterThrottlingTest.java:
##########
@@ -36,6 +37,7 @@
import java.util.stream.LongStream;
/** Test class for rate limiting functionalities of {@link AsyncSinkWriter}. */
+@Disabled("FLINK-31472")
Review Comment:
```suggestion
@Ignore("FLINK-31472")
```
this is a junit4 test (because it imports `org.junit.Test` rather than `org.junit.jupiter.api.Test`). Therefore, we would have to rely on the `org.junit.Ignore` annotation here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-31472] Disable Intermittently failing throttling test [flink]
Posted by "vahmed-hamdy (via GitHub)" <gi...@apache.org>.
vahmed-hamdy commented on PR #24175:
URL: https://github.com/apache/flink/pull/24175#issuecomment-1916912004
@XComp I have addressed your comments, the pipeline is ironically failing for another unstable test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-31472] Disable Intermittently failing throttling test [flink]
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on code in PR #24175:
URL: https://github.com/apache/flink/pull/24175#discussion_r1470860598
##########
flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriterThrottlingTest.java:
##########
@@ -36,6 +37,7 @@
import java.util.stream.LongStream;
/** Test class for rate limiting functionalities of {@link AsyncSinkWriter}. */
+@Disabled("FLINK-31472")
Review Comment:
You also want to rebase, I guess to have a stable master base again for CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-31472] Disable Intermittently failing throttling test [flink]
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp closed pull request #24175: [FLINK-31472] Disable Intermittently failing throttling test
URL: https://github.com/apache/flink/pull/24175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-31472] Disable Intermittently failing throttling test [flink]
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #24175:
URL: https://github.com/apache/flink/pull/24175#issuecomment-1916929055
> @XComp I have addressed your comments, the pipeline is ironically failing for another unstable test
The CI pipeline is not failing because of an unstable test. It's failing because your PR is based on a version where `master` was unfortunately broken due to some compilation error. Rebasing the branch should fix the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-31472] Disable Intermittently failing throttling test [flink]
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #24175:
URL: https://github.com/apache/flink/pull/24175#issuecomment-1987866921
According to [this comment in FLINK-31472](https://issues.apache.org/jira/browse/FLINK-31472?focusedCommentId=17825202&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17825202) we're gonna go ahead trying to fix the issue without disabling the test for now. I'm gonna close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-31472] Disable Intermittently failing throttling test [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #24175:
URL: https://github.com/apache/flink/pull/24175#issuecomment-1905843071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5e2429d6ced8b655175f14df8cf6083b3e5fa0b6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5e2429d6ced8b655175f14df8cf6083b3e5fa0b6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5e2429d6ced8b655175f14df8cf6083b3e5fa0b6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-31472] Disable Intermittently failing throttling test [flink]
Posted by "vahmed-hamdy (via GitHub)" <gi...@apache.org>.
vahmed-hamdy commented on code in PR #24175:
URL: https://github.com/apache/flink/pull/24175#discussion_r1470844725
##########
flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriterThrottlingTest.java:
##########
@@ -36,6 +37,7 @@
import java.util.stream.LongStream;
/** Test class for rate limiting functionalities of {@link AsyncSinkWriter}. */
+@Disabled("FLINK-31472")
Review Comment:
yes good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org