You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/15 12:52:20 UTC
[GitHub] [spark] kyoty opened a new pull request #32191: [SPARK-35902] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
kyoty opened a new pull request #32191:
URL: https://github.com/apache/spark/pull/32191
### What changes were proposed in this pull request?
the auto-generated rdd's name in the storage tab should be truncated as a single line if it is too long.
### Why are the changes needed?
to make the ui shows more friendly.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
just a simple modifition in css, manual test works well like below:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #32191:
URL: https://github.com/apache/spark/pull/32191#discussion_r614788834
##########
File path: core/src/main/scala/org/apache/spark/ui/UIUtils.scala
##########
@@ -325,7 +325,8 @@ private[spark] object UIUtils extends Logging {
<div class="container-fluid">
<div class="row">
<div class="col-12">
- <h3 style="vertical-align: bottom; display: inline-block;">
+ <h3 style="vertical-align: bottom; white-space: nowrap; overflow: hidden;
+ text-overflow: ellipsis;">
Review comment:
It's better to have one more whitespace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-820868821
**[Test build #137455 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137455/testReport)** for PR 32191 at commit [`7312c99`](https://github.com/apache/spark/commit/7312c99b093f9140306ce0c2dcea18fab6714c39).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-821796439
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32191: [SPARK-35092][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-822170347
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-821806867
**[Test build #137504 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137504/testReport)** for PR 32191 at commit [`b2f2ff3`](https://github.com/apache/spark/commit/b2f2ff3523c31207bd25af7f1f5b4c1361d0e178).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-821089612
**[Test build #137481 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137481/testReport)** for PR 32191 at commit [`6e16f16`](https://github.com/apache/spark/commit/6e16f16bde8f36999183679c49a66b427c803e7a).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-821797933
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42078/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-820866489
ok to test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32191: [SPARK-35902] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-820510515
**[Test build #752514284](https://github.com/kyoty/spark/actions/runs/752514284)** for PR 32191 at commit [`7312c99`](https://github.com/kyoty/spark/commit/7312c99b093f9140306ce0c2dcea18fab6714c39).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32191: [SPARK-35092][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-822340166
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137577/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32191: [SPARK-35092][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-822170347
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kyoty commented on pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
kyoty commented on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-821072540
@sarutak the screenshots have been attached, please help to reveive this, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-820868369
**[Test build #137455 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137455/testReport)** for PR 32191 at commit [`7312c99`](https://github.com/apache/spark/commit/7312c99b093f9140306ce0c2dcea18fab6714c39).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #32191: [SPARK-35092][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-822112947
@kyoty
I checked whether the GitHub Actions jobs finished successfully but I see the following message.
```
Actions jobs for this repository have been disabled by GitHub staff. If you are the repository owner, you can contact support via https://github.com/contact for more information.
```
Do you have any idea of this?
Anyway, I don't think this change affects the GA failure because it's just a style change and Jenkins passes so I'll merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-821116330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32191: [SPARK-35092][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-822190539
**[Test build #137577 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137577/testReport)** for PR 32191 at commit [`b2f2ff3`](https://github.com/apache/spark/commit/b2f2ff3523c31207bd25af7f1f5b4c1361d0e178).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-820868369
**[Test build #137455 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137455/testReport)** for PR 32191 at commit [`7312c99`](https://github.com/apache/spark/commit/7312c99b093f9140306ce0c2dcea18fab6714c39).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-820849044
cc @gengliangwang and @sarutak FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-821131991
I left one minor comment. Otherwise, it LGTM and I confirmed this change works on my laptop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-821180824
**[Test build #137481 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137481/testReport)** for PR 32191 at commit [`6e16f16`](https://github.com/apache/spark/commit/6e16f16bde8f36999183679c49a66b427c803e7a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-820868831
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137455/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-821791509
**[Test build #758120022](https://github.com/kyoty/spark/actions/runs/758120022)** for PR 32191 at commit [`b2f2ff3`](https://github.com/kyoty/spark/commit/b2f2ff3523c31207bd25af7f1f5b4c1361d0e178).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-821071185
**[Test build #755238562](https://github.com/kyoty/spark/actions/runs/755238562)** for PR 32191 at commit [`6e16f16`](https://github.com/kyoty/spark/commit/6e16f16bde8f36999183679c49a66b427c803e7a).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-821810625
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137504/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kyoty commented on a change in pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
kyoty commented on a change in pull request #32191:
URL: https://github.com/apache/spark/pull/32191#discussion_r615229140
##########
File path: core/src/main/scala/org/apache/spark/ui/UIUtils.scala
##########
@@ -325,7 +325,8 @@ private[spark] object UIUtils extends Logging {
<div class="container-fluid">
<div class="row">
<div class="col-12">
- <h3 style="vertical-align: bottom; display: inline-block;">
+ <h3 style="vertical-align: bottom; white-space: nowrap; overflow: hidden;
+ text-overflow: ellipsis;">
Review comment:
Thanks @sarutak done this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #32191: [SPARK-35092][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-822112947
@kyoty
I checked whether the GitHub Actions jobs finished successfully but I see the following message.
```
Actions jobs for this repository have been disabled by GitHub staff. If you are the repository owner, you can contact support via https://github.com/contact for more information.
```
Do you have any idea about this?
Anyway, I don't think this change affects the GA failure because it's just a style change and Jenkins passes so I'll merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-821089612
**[Test build #137481 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137481/testReport)** for PR 32191 at commit [`6e16f16`](https://github.com/apache/spark/commit/6e16f16bde8f36999183679c49a66b427c803e7a).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32191: [SPARK-35092][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-822333280
**[Test build #137577 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137577/testReport)** for PR 32191 at commit [`b2f2ff3`](https://github.com/apache/spark/commit/b2f2ff3523c31207bd25af7f1f5b4c1361d0e178).
* This patch passes all tests.
* This patch **does not merge cleanly**.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32191: [SPARK-35902] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-820399025
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-821188378
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137481/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-821791626
**[Test build #137504 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137504/testReport)** for PR 32191 at commit [`b2f2ff3`](https://github.com/apache/spark/commit/b2f2ff3523c31207bd25af7f1f5b4c1361d0e178).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-821117622
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42056/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-821117622
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42056/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-820880875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-821797933
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42078/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kyoty commented on pull request #32191: [SPARK-35092][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
kyoty commented on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-826525568
@sarutak Thanks for your help and review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-820399025
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32191: [SPARK-35092][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-822340166
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137577/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #32191: [SPARK-35092][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-822191674
@kyoty I think it's better to ask GitHub stuff as the error message suggests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak closed pull request #32191: [SPARK-35092][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
sarutak closed pull request #32191:
URL: https://github.com/apache/spark/pull/32191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32191: [SPARK-35902] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-820509718
**[Test build #752511546](https://github.com/kyoty/spark/actions/runs/752511546)** for PR 32191 at commit [`2ea50b9`](https://github.com/kyoty/spark/commit/2ea50b942a433806de8605ac9023a7be9bc60727).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-821810625
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137504/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-820868831
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137455/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-820884713
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42030/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32191: [SPARK-35092][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-822190539
**[Test build #137577 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137577/testReport)** for PR 32191 at commit [`b2f2ff3`](https://github.com/apache/spark/commit/b2f2ff3523c31207bd25af7f1f5b4c1361d0e178).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kyoty commented on pull request #32191: [SPARK-35092][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
kyoty commented on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-826525568
@sarutak Thanks for your help and review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-820884713
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42030/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #32191:
URL: https://github.com/apache/spark/pull/32191#discussion_r614538080
##########
File path: core/src/main/scala/org/apache/spark/ui/UIUtils.scala
##########
@@ -325,7 +325,7 @@ private[spark] object UIUtils extends Logging {
<div class="container-fluid">
<div class="row">
<div class="col-12">
- <h3 style="vertical-align: bottom; display: inline-block;">
+ <h3 style="vertical-align: bottom; white-space: nowrap; overflow: hidden; text-overflow: ellipsis;">
Review comment:
This line exceeds 100 characters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kyoty commented on pull request #32191: [SPARK-35092][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
kyoty commented on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-822130317
@HyukjinKwon do you have any idea about sarutak mentioned above ? I have never seen this warning before..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-821791626
**[Test build #137504 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137504/testReport)** for PR 32191 at commit [`b2f2ff3`](https://github.com/apache/spark/commit/b2f2ff3523c31207bd25af7f1f5b4c1361d0e178).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-820856925
Hi @kyoty, could you show a screen shot in the description from which we can see the effect of this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32191: [SPARK-35902][UI] the auto-generated rdd's name in the storage tab should be truncated if it is too long.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32191:
URL: https://github.com/apache/spark/pull/32191#issuecomment-821188378
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137481/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org