[GitHub] [pulsar] lhotari commented on a change in pull request #10961: Fix incorrect port of advertisedListener

[GitBox <gi...@apache.org>]

lhotari commented on a change in pull request #10961:
URL: https://github.com/apache/pulsar/pull/10961#discussion_r654189135



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
##########
@@ -1360,10 +1360,13 @@ public ShutdownService getShutdownService() {
         return shutdownService;
     }
 
+    public static String advertisedAddress(ServiceConfiguration config) {

Review comment:
       @315157973 Great. It is still a bit unclear to me what is the difference of this method compared to org.apache.pulsar.broker.ServiceConfigurationUtils.getAppliedAdvertisedAddress added in #10312 . Do you have an answer for that question?

##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
##########
@@ -1360,10 +1360,13 @@ public ShutdownService getShutdownService() {
         return shutdownService;
     }
 
+    public static String advertisedAddress(ServiceConfiguration config) {

Review comment:
       > Why the advertisedAddress() method does not obtain the advertisedListener has been described in PR
   
   It's not clear to me how it is described. Could you elaborate? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org