You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by "Victor J. Orlikowski" <v....@gte.net> on 2000/07/12 20:39:22 UTC
[PATCH] Compile fixes in mod_mmap_static
Fixes minor bugs (unneeded semi, and a differing type).
Index: src/modules/experimental/mod_mmap_static.c
===================================================================
RCS file: /cvs/apache/apache-2.0/src/modules/experimental/mod_mmap_static.c,v
retrieving revision 1.17
diff -u -r1.17 mod_mmap_static.c
--- mod_mmap_static.c 2000/07/05 19:13:58 1.17
+++ mod_mmap_static.c 2000/07/12 18:33:47
@@ -312,7 +312,7 @@
ap_send_mmap (match->mm, r, 0, match->finfo.size);
}
else {
- long length;
+ unsigned long length;
ap_off_t offset;
while (ap_each_byterange(r, &offset, &length)) {
ap_send_mmap(match->mm, r, offset, length);
@@ -333,7 +333,7 @@
{
ap_hook_post_config(mmap_post_config, NULL, NULL, AP_HOOK_MIDDLE);
ap_hook_translate_name(mmap_static_xlat, NULL, NULL, AP_HOOK_LAST);
-};
+}
static const handler_rec mmap_static_handlers[] =
{
{
--
Victor J. Orlikowski v.j.orlikowski@gte.net
vjo@raleigh.ibm.com
vjo@us.ibm.com
Re: [PATCH] Compile fixes in mod_mmap_static
Posted by Greg Ames <gr...@raleigh.ibm.com>.
Jeff Trawick wrote:
>
>
> OTOH, mod_mmap_static should go away soon, right? 9 days ago (or so),
> Greg Ames was about to get the mod_mmap_static-type support in
> mod_file_cache working IIRC.
>
The MmapFile side of mod_file_cache is working fine now. So
mod_mmap_static could go away, I guess.
Greg
Re: [PATCH] Compile fixes in mod_mmap_static
Posted by Jeff Trawick <tr...@ibm.net>.
> Date: Wed, 12 Jul 2000 14:39:22 -0400 (EDT)
> From: "Victor J. Orlikowski" <v....@gte.net>
>
> Fixes minor bugs (unneeded semi, and a differing type).
>
>
> Index: src/modules/experimental/mod_mmap_static.c
> ===================================================================
> RCS file: /cvs/apache/apache-2.0/src/modules/experimental/mod_mmap_static.c,v
> retrieving revision 1.17
> diff -u -r1.17 mod_mmap_static.c
> --- mod_mmap_static.c 2000/07/05 19:13:58 1.17
> +++ mod_mmap_static.c 2000/07/12 18:33:47
> @@ -312,7 +312,7 @@
> ap_send_mmap (match->mm, r, 0, match->finfo.size);
> }
> else {
> - long length;
> + unsigned long length;
> ap_off_t offset;
> while (ap_each_byterange(r, &offset, &length)) {
> ap_send_mmap(match->mm, r, offset, length);
Let's see... Third parm to ap_each_byterange() is ap_size_t *; fourth
parm to ap_send_mmap() is size_t. Instead of changing length to
unsigned long, consider changing length to ap_size_t. Perhaps
ap_send_mmap() should be tweaked as well (to use the APR type).
OTOH, mod_mmap_static should go away soon, right? 9 days ago (or so),
Greg Ames was about to get the mod_mmap_static-type support in
mod_file_cache working IIRC.
--
Jeff Trawick | trawick@ibm.net | PGP public key at web site:
http://www.geocities.com/SiliconValley/Park/9289/
Born in Roswell... married an alien...