[GitHub] [spark] jiangxb1987 commented on a change in pull request #24497: [SPARK-27630][CORE] Properly handle task end events from completed stages

[GitBox <gi...@apache.org>]

jiangxb1987 commented on a change in pull request #24497: [SPARK-27630][CORE] Properly handle task end events from completed stages
URL: https://github.com/apache/spark/pull/24497#discussion_r289234931
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala
 ##########
 @@ -645,30 +645,30 @@ private[spark] class ExecutorAllocationManager(
    */
   private[spark] class ExecutorAllocationListener extends SparkListener {
 
-    private val stageIdToNumTasks = new mutable.HashMap[Int, Int]
-    // Number of running tasks per stage including speculative tasks.
-    // Should be 0 when no stages are active.
-    private val stageIdToNumRunningTask = new mutable.HashMap[Int, Int]
-    private val stageIdToTaskIndices = new mutable.HashMap[Int, mutable.HashSet[Int]]
+    private val stageIdToNumTasks = new mutable.HashMap[(Int, Int), Int]
 
 Review comment:
   Also update the variable names to `stageAttemptTo...` ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org