Re: [PATCH] issue 619 APR patch, issue 532 read-only admin

[Philip Martin <ph...@codematters.co.uk>]

Philip Martin <ph...@codematters.co.uk> writes:

> Greg Stein <gs...@lyra.org> writes:
> 
> > I'll apply the APR side of this. Thanks for the patch!
> 
> Thanks for applying it, however it's got a bit mangled. In
> apr_file_info.h the magic number APR_FILE_SOURCE_PERMS needs to be
> different from all possible perms. I used (APR_OS_DEFAULT+1) you have
> used 0x1000 which corresponds to APR_UEXECUTE. Ox10000, i.e. one more
> zero, would be OK.

Here's a patch


Index: include/apr_file_info.h
===================================================================
RCS file: /home/cvspublic/apr/include/apr_file_info.h,v
retrieving revision 1.26
diff -u -r1.26 apr_file_info.h
--- include/apr_file_info.h	1 Feb 2002 14:56:30 -0000	1.26
+++ include/apr_file_info.h	1 Feb 2002 20:40:05 -0000
@@ -109,7 +109,7 @@
 #define APR_OS_DEFAULT  0xFFFF /**< use OS's default permissions */
 
 /* additional permission flags for apr_file_copy  and apr_file_append */
-#define APR_FILE_SOURCE_PERMS 0x1000 /**< Copy source file's permissions */
+#define APR_FILE_SOURCE_PERMS 0x10000 /**< Copy source file's permissions */
 
 /** @} */
 

-- 
Philip