You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "vamossagar12 (via GitHub)" <gi...@apache.org> on 2023/06/30 11:20:14 UTC
[GitHub] [kafka] vamossagar12 opened a new pull request, #13939: [MINOR] Correcting few WARN log lines in DistributedHerder#handleRebalance
vamossagar12 opened a new pull request, #13939:
URL: https://github.com/apache/kafka/pull/13939
Minor improvements to comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante commented on a diff in pull request #13939: [MINOR] Correcting few WARN log lines in DistributedHerder#handleRebalance
Posted by "C0urante (via GitHub)" <gi...@apache.org>.
C0urante commented on code in PR #13939:
URL: https://github.com/apache/kafka/pull/13939#discussion_r1247916426
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##########
@@ -1657,13 +1657,13 @@ private boolean handleRebalanceCompleted() {
if (assignment.failed()) {
needsRejoin = true;
if (isLeader()) {
- log.warn("Join group completed, but assignment failed and we are the leader. Reading to end of config and retrying.");
+ log.warn("Join group completed, but the assignment failed and we are the leader. Reading to end of config and retrying.");
needsReadToEnd = true;
} else if (configState.offset() < assignment.offset()) {
- log.warn("Join group completed, but assignment failed and we lagging. Reading to end of config and retrying.");
+ log.warn("Join group completed, but the assignment failed and we are lagging. Reading to end of config and retrying.");
Review Comment:
I think the only change we need here is "we are lagging"; "assignment" is fine without a preceeding "the".
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##########
@@ -1657,13 +1657,13 @@ private boolean handleRebalanceCompleted() {
if (assignment.failed()) {
needsRejoin = true;
if (isLeader()) {
- log.warn("Join group completed, but assignment failed and we are the leader. Reading to end of config and retrying.");
+ log.warn("Join group completed, but the assignment failed and we are the leader. Reading to end of config and retrying.");
needsReadToEnd = true;
} else if (configState.offset() < assignment.offset()) {
- log.warn("Join group completed, but assignment failed and we lagging. Reading to end of config and retrying.");
+ log.warn("Join group completed, but the assignment failed and we are lagging. Reading to end of config and retrying.");
Review Comment:
I think the only change we need here is "we are lagging"; "assignment" is fine without a preceding "the".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante merged pull request #13939: [MINOR] Correcting few WARN log lines in DistributedHerder#handleRebalance
Posted by "C0urante (via GitHub)" <gi...@apache.org>.
C0urante merged PR #13939:
URL: https://github.com/apache/kafka/pull/13939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13939: [MINOR] Correcting few WARN log lines in DistributedHerder#handleRebalance
Posted by "vamossagar12 (via GitHub)" <gi...@apache.org>.
vamossagar12 commented on code in PR #13939:
URL: https://github.com/apache/kafka/pull/13939#discussion_r1248058129
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##########
@@ -1657,13 +1657,13 @@ private boolean handleRebalanceCompleted() {
if (assignment.failed()) {
needsRejoin = true;
if (isLeader()) {
- log.warn("Join group completed, but assignment failed and we are the leader. Reading to end of config and retrying.");
+ log.warn("Join group completed, but the assignment failed and we are the leader. Reading to end of config and retrying.");
needsReadToEnd = true;
} else if (configState.offset() < assignment.offset()) {
- log.warn("Join group completed, but assignment failed and we lagging. Reading to end of config and retrying.");
+ log.warn("Join group completed, but the assignment failed and we are lagging. Reading to end of config and retrying.");
Review Comment:
Removed the unwanted changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org