[GitHub] [superset] EugeneTorap commented on pull request #21739: build: Make Docker image extensible

[GitBox <gi...@apache.org>]

EugeneTorap commented on PR #21739:
URL: https://github.com/apache/superset/pull/21739#issuecomment-1272600064

   Hi @sinhashubham95
   Can you explain why do we need the frontend source code in the final production image?
   How do you plan to use & modify it in the final image?
   If you know we build all UI source code into minified bundles and serve it via python server.
   For us, two criteria for the docker image are important: the speed of the build and the lightness of the image.
   Your PR makes the final image fatter and removing the node modules slows down the speed in Node section.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org