[GitHub] [jmeter] woonsan commented on a change in pull request #651: Don't assume we have correct JSON at edit time

[GitBox <gi...@apache.org>]

woonsan commented on a change in pull request #651:
URL: https://github.com/apache/jmeter/pull/651#discussion_r612353542



##########
File path: src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/util/GraphQLRequestParamUtils.java
##########
@@ -79,27 +76,32 @@ public static boolean isGraphQLContentType(final String contentType) {
      * @throws RuntimeException if JSON serialization fails for some reason due to any runtime environment issues
      */
     public static String toPostBodyString(final GraphQLRequestParams params) {
-        final ObjectMapper mapper = new ObjectMapper();
-        final ObjectNode postBodyJson = mapper.createObjectNode();
-        postBodyJson.set(OPERATION_NAME_FIELD,
-                JsonNodeFactory.instance.textNode(StringUtils.trimToNull(params.getOperationName())));
-
+        final StringBuilder result = new StringBuilder();

Review comment:
       Hi @FSchumacher / @vlsi ,
   
   I found "a" solution in PR #660 . Would you mind reviewing the PR?
   
   Thanks,
   
   Woonsan




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org