You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "mappjzc (via GitHub)" <gi...@apache.org> on 2023/03/09 15:44:25 UTC
[GitHub] [incubator-devlake] mappjzc opened a new pull request, #4630: feat: add deploy environments with e2e test
mappjzc opened a new pull request, #4630:
URL: https://github.com/apache/incubator-devlake/pull/4630
### Summary
Add deploy collect for the deploy project.
Add extract to get env data by the plan.
### Screenshots
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on a diff in pull request #4630: feat: add deploy environments with e2e test
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on code in PR #4630:
URL: https://github.com/apache/incubator-devlake/pull/4630#discussion_r1133684454
##########
backend/plugins/bamboo/tasks/deploy_extractor.go:
##########
@@ -32,9 +32,32 @@ var _ plugin.SubTaskEntryPoint = ExtractDeploy
func ExtractDeploy(taskCtx plugin.SubTaskContext) errors.Error {
rawDataSubTaskArgs, data := CreateRawDataSubTaskArgs(taskCtx, RAW_DEPLOY_TABLE)
+ db := taskCtx.GetDal()
+ clauses := []dal.Clause{
+ dal.Select("plan_key"),
+ dal.From(models.BambooPlan{}.TableName()),
+ dal.Where("project_key = ? and connection_id=?", data.Options.ProjectKey, data.Options.ConnectionId),
+ }
+ cursor, err := db.Cursor(
+ clauses...,
+ )
+ if err != nil {
+ return err
+ }
+
Review Comment:
`cursor` is not closed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh merged pull request #4630: feat: add deploy environments with e2e test
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh merged PR #4630:
URL: https://github.com/apache/incubator-devlake/pull/4630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org