You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/14 06:41:01 UTC

[GitHub] [pulsar] shibd opened a new pull request #14674: fix flaky-test: SubscriptionSeekTest.testShouldCloseAllConsumersForMu…

shibd opened a new pull request #14674:
URL: https://github.com/apache/pulsar/pull/14674


   ### Motivation
   
   #11703
   
   When `conumser1` call seek, need wait for `conumser2` also reconnect success, then assert.
   
   
   ### Modifications
   - add wait for `conumser2` reconnect.
   
   ### Documentation
   - [x] `no-need-doc` 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] shibd commented on pull request #14674: fix flaky-test: SubscriptionSeekTest.testShouldCloseAllConsumersForMu…

Posted by GitBox <gi...@apache.org>.

shibd commented on pull request #14674:
URL: https://github.com/apache/pulsar/pull/14674#issuecomment-1066489567


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on a change in pull request #14674: fix flaky-test: SubscriptionSeekTest.testShouldCloseAllConsumersForMu…

Posted by GitBox <gi...@apache.org>.

codelipenghui commented on a change in pull request #14674:
URL: https://github.com/apache/pulsar/pull/14674#discussion_r825949495



##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/SubscriptionSeekTest.java
##########
@@ -560,7 +560,7 @@ public void testShouldCloseAllConsumersForMultipleConsumerDispatcherWhenSeek() t
                 .subscriptionName("my-subscription")
                 .subscribe();
 
-        pulsarClient.newConsumer()
+        org.apache.pulsar.client.api.Consumer<byte[]> consumer2 = pulsarClient.newConsumer()

Review comment:
       Close the consumer after the test.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #14674: Fix Flaky-test: SubscriptionSeekTest.testShouldCloseAllConsumersForMultipleConsumerDispatcherWhenSeek

Posted by GitBox <gi...@apache.org>.

codelipenghui merged pull request #14674:
URL: https://github.com/apache/pulsar/pull/14674


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org