You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by wynhbh <gi...@git.apache.org> on 2017/05/21 02:29:03 UTC
[GitHub] storm pull request #2128: update EsPercolateBolt.java
GitHub user wynhbh opened a pull request:
https://github.com/apache/storm/pull/2128
update EsPercolateBolt.java
update elasticsearch client api
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wynhbh/storm patch-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2128.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2128
----
commit a90e6351fab3f6a288510a6bd419736c5836505b
Author: wynhbh <wy...@gmail.com>
Date: 2017-05-21T02:28:23Z
update EsPercolateBolt.java
update elasticsearch client api
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2128: update EsPercolateBolt.java
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2128#discussion_r121072928
--- Diff: external/storm-elasticsearch/src/main/java/org/apache/storm/elasticsearch/bolt/EsPercolateBolt.java ---
@@ -81,7 +81,7 @@ public void process(Tuple tuple) {
Map<String, String> indexParams = new HashMap<>();
indexParams.put(type, null);
String percolateDoc = "{\"doc\": " + source + "}";
- Response response = client.performRequest("get", getEndpoint(index, type, "_percolate"), new HashMap<>(), new StringEntity(percolateDoc));
+ Response response = client.performRequest("get", getEndpoint(index, type, "_percolate"), new HashMap<String, String>(), new StringEntity(percolateDoc));
--- End diff --
What's rationale of this patch? Did it occur compile issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2128: update EsPercolateBolt.java
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2128
---
[GitHub] storm issue #2128: update EsPercolateBolt.java
Posted by wynhbh <gi...@git.apache.org>.
Github user wynhbh commented on the issue:
https://github.com/apache/storm/pull/2128
public Response performRequest(String method, String endpoint, Map<> params, Header... headers)
->
public Response performRequest(String method, String endpoint, Map<String, String> params, Header... headers)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---