[GitHub] [hbase] Apache9 commented on a change in pull request #820: HBASE-23286 Improve MTTR: Split WAL to HFile

[GitBox <gi...@apache.org>]

Apache9 commented on a change in pull request #820: HBASE-23286 Improve MTTR: Split WAL to HFile
URL: https://github.com/apache/hbase/pull/820#discussion_r346337711
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/BoundedWriterCreationOutputSink.java
 ##########
 @@ -40,13 +43,13 @@
  * Bounded means the output streams will be no more than the size of threadpool
  */
 @InterfaceAudience.Private
-public class BoundedLogWriterCreationOutputSink extends LogRecoveredEditsOutputSink {
+public class BoundedWriterCreationOutputSink extends RecoveredEditsOutputSink {
 
 Review comment:
   In general, I prefer we have a base class and then two sub classes, one is for writting out recovered wals, and the other is for writting out recovered hfiles. Making HFile extends WAL is a bit strange.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services