You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/28 09:09:07 UTC

[GitHub] [apisix-dashboard] Rapiz1 opened a new pull request #523: style: Drop `npm run` in package.json

Rapiz1 opened a new pull request #523:
URL: https://github.com/apache/apisix-dashboard/pull/523


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [x] Bug fix
   - [ ] New feature provided
   - [ ] Improve performance
   
   - Related issues
   
   ___
   ### Bugfix
   - Description
   In [README/Build the dashboard](https://github.com/apache/apisix-dashboard#build-the-dashboard), only `yarn` is mentioned but `npm` is used instead of `yarn` in `package.json` multiple times. It will cause confusion to users who have installed yarn according to README but without `npm` on their machines.
   
   - How to fix?
   `npm` is not actually used in the project. In `package.json`, it acts as a command caller. So simply dropping `npm` works.
   All `npm` has been replaced to `yarn`.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #523: style: Drop `npm run` in package.json

Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #523:
URL: https://github.com/apache/apisix-dashboard/pull/523


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org