You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/01 16:47:09 UTC

[GitHub] pgandhi999 commented on issue #22806: [SPARK-25250][CORE] : Late zombie task completions handled correctly even before new taskset launched

pgandhi999 commented on issue #22806: [SPARK-25250][CORE] : Late zombie task completions handled correctly even before new taskset launched
URL: https://github.com/apache/spark/pull/22806#issuecomment-459787467
 
 
   @squito Hmm indeed that is an interesting problem. I was going through the code and saw that the method `markPartitionCompleted` in `TaskSetManager` is updating `successful` for task indices. What if we make `successful` into a ConcurrentHashMap? That should avoid the problem of synchronizing on the whole `TaskSchedulerImpl`. Similar work has been done previously in PR #22221 (https://github.com/apache/spark/pull/22221). What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org