You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by mm...@apache.org on 2023/03/20 16:43:03 UTC
[bookkeeper] branch master updated: Fix compaction threshold default value precision problem. (#3871)
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push:
new e19cb9d822 Fix compaction threshold default value precision problem. (#3871)
e19cb9d822 is described below
commit e19cb9d822c316a13cbf015fd4a627fce44172be
Author: Yan Zhao <ho...@apache.org>
AuthorDate: Tue Mar 21 00:42:57 2023 +0800
Fix compaction threshold default value precision problem. (#3871)
* Fix compaction threshold precision problem.
* Fix compaction threshold precision problem.
---
.../java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java | 8 ++++----
.../main/java/org/apache/bookkeeper/conf/ServerConfiguration.java | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java
index bdffd689a5..c06df7c228 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java
@@ -218,7 +218,7 @@ public class GarbageCollectorThread implements Runnable {
this.throttler = new AbstractLogCompactor.Throttler(conf);
if (minorCompactionInterval > 0 && minorCompactionThreshold > 0) {
- if (minorCompactionThreshold > 1.0f) {
+ if (minorCompactionThreshold > 1.0d) {
throw new IOException("Invalid minor compaction threshold "
+ minorCompactionThreshold);
}
@@ -230,16 +230,16 @@ public class GarbageCollectorThread implements Runnable {
}
if (isForceAllowCompaction) {
- if (minorCompactionThreshold > 0 && minorCompactionThreshold < 1.0f) {
+ if (minorCompactionThreshold > 0 && minorCompactionThreshold < 1.0d) {
isForceMinorCompactionAllow = true;
}
- if (majorCompactionThreshold > 0 && majorCompactionThreshold < 1.0f) {
+ if (majorCompactionThreshold > 0 && majorCompactionThreshold < 1.0d) {
isForceMajorCompactionAllow = true;
}
}
if (majorCompactionInterval > 0 && majorCompactionThreshold > 0) {
- if (majorCompactionThreshold > 1.0f) {
+ if (majorCompactionThreshold > 1.0d) {
throw new IOException("Invalid major compaction threshold "
+ majorCompactionThreshold);
}
diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
index 4db536ab49..cf74f6af01 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
@@ -1676,7 +1676,7 @@ public class ServerConfiguration extends AbstractConfiguration<ServerConfigurati
* @return threshold of minor compaction
*/
public double getMinorCompactionThreshold() {
- return getDouble(MINOR_COMPACTION_THRESHOLD, 0.2f);
+ return getDouble(MINOR_COMPACTION_THRESHOLD, 0.2d);
}
/**
@@ -1704,7 +1704,7 @@ public class ServerConfiguration extends AbstractConfiguration<ServerConfigurati
* @return threshold of major compaction
*/
public double getMajorCompactionThreshold() {
- return getDouble(MAJOR_COMPACTION_THRESHOLD, 0.8f);
+ return getDouble(MAJOR_COMPACTION_THRESHOLD, 0.8d);
}
/**