[GitHub] [spark] LuciferYang commented on a diff in pull request #39789: [SPARK-42228][BUILD][CONNECT] Add shade and relocation rule of grpc to connect-client-jvm module

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on code in PR #39789:
URL: https://github.com/apache/spark/pull/39789#discussion_r1092643649


##########
connector/connect/client/jvm/pom.xml:
##########
@@ -105,11 +105,16 @@
           <artifactSet>
             <includes>
               <include>com.google.guava:*</include>
+              <include>io.grpc:*:</include>

Review Comment:
   @zhenlineo When I run 
   
   `mvn clean install -DskipTests -pl connector/connect/client/jvm`
   
   I can see the shaded logs of grpc, and the server side also writes the same
   
   <img width="857" alt="image" src="https://user-images.githubusercontent.com/1475305/215918872-0d5ad3f1-da33-4851-8f74-78e153caacc0.png">
   
   https://github.com/apache/spark/blob/4d37e7816ce83dc5928b0d42a536304cb49eb0a3/connector/connect/server/pom.xml#L244
   
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org