You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Michael Stack (Jira)" <ji...@apache.org> on 2021/02/10 16:33:00 UTC

[jira] [Resolved] (HBASE-25364) Redo the getMidPoint() in HFileWriterImpl to get rid of the double comparison process

     [ https://issues.apache.org/jira/browse/HBASE-25364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Stack resolved HBASE-25364.
-----------------------------------
    Fix Version/s: 2.5.0
                   3.0.0-alpha-1
     Hadoop Flags: Reviewed
       Resolution: Fixed

Thank you for the nice improvement [~GeorryHuang] (thanks for thorough review [~niuyulin]). Merged to branch-2 and master.

> Redo the getMidPoint() in HFileWriterImpl to get rid of the double comparison process
> -------------------------------------------------------------------------------------
>
>                 Key: HBASE-25364
>                 URL: https://issues.apache.org/jira/browse/HBASE-25364
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Zhuoyue Huang
>            Assignee: Zhuoyue Huang
>            Priority: Minor
>             Fix For: 3.0.0-alpha-1, 2.5.0
>
>
> There is a TODO like this "TODO: Redo so only a single pass over the arrays rather than one to  compare and then a second composing midpoint." in getMidpoint()  of class HFileWriteImpl
>   
>  The old logic compares the left byte array and the right byte array twice： 
>  # A comparison is performed before composing MinimumMidpointArray
>  # During composing of MinimumMidpointArray, bytes were comparing again
>  
>  My optimization  combines them into one



--
This message was sent by Atlassian Jira
(v8.3.4#803005)