You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/11/20 04:36:51 UTC

[GitHub] [hudi] n3nash commented on a change in pull request #2249: [HUDI-1358] Fix leaks in DiskBasedMap and LazyFileIterable

n3nash commented on a change in pull request #2249:
URL: https://github.com/apache/hudi/pull/2249#discussion_r527392458



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/util/collection/LazyFileIterable.java
##########
@@ -38,6 +38,8 @@
   // Stores the key and corresponding value's latest metadata spilled to disk
   private final Map<T, DiskBasedMap.ValueMetadata> inMemoryMetadataOfSpilledData;
 
+  private transient Thread shutdownThread = null;

Review comment:
       @bvaradar Any reason this needs to be transient ? Are we serializing this ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org