You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2013/05/31 01:10:22 UTC
Review Request: Moved proc::alive function to os::alive in os.hpp and
improved its documentation. (libstout)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11553/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
Description
-------
Rebased against master. Previous review received "shipit"s but got lost.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 1b3fb47d7567b5467fef2a2bb15d5c4a2ea42aa5
Diff: https://reviews.apache.org/r/11553/diff/
Testing
-------
make check.
Thanks,
Jiang Yan Xu
Re: Review Request: Moved proc::alive function to os::alive in os.hpp and
improved its documentation. (libstout)
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11553/#review21254
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On May 30, 2013, 11:10 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11553/
> -----------------------------------------------------------
>
> (Updated May 30, 2013, 11:10 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> Rebased against master. Previous review received "shipit"s but got lost.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 1b3fb47d7567b5467fef2a2bb15d5c4a2ea42aa5
>
> Diff: https://reviews.apache.org/r/11553/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request: Moved proc::alive function to os::alive in os.hpp and
improved its documentation. (libstout)
Posted by Jiang Yan Xu <ya...@jxu.me>.
> On June 21, 2013, 5:42 p.m., Ben Mahler wrote:
> > I think we can discard this one now that we have the process utilities?
I think your version of os::alive has as different meaning: zombie == alive in this review and zombie != alive in yours... Let me see if this changes reaper's behavior.
- Jiang Yan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11553/#review22262
-----------------------------------------------------------
On May 30, 2013, 11:10 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11553/
> -----------------------------------------------------------
>
> (Updated May 30, 2013, 11:10 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> Rebased against master. Previous review received "shipit"s but got lost.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 1b3fb47d7567b5467fef2a2bb15d5c4a2ea42aa5
>
> Diff: https://reviews.apache.org/r/11553/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request: Moved proc::alive function to os::alive in os.hpp and
improved its documentation. (libstout)
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11553/#review22262
-----------------------------------------------------------
I think we can discard this one now that we have the process utilities?
- Ben Mahler
On May 30, 2013, 11:10 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11553/
> -----------------------------------------------------------
>
> (Updated May 30, 2013, 11:10 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> Rebased against master. Previous review received "shipit"s but got lost.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 1b3fb47d7567b5467fef2a2bb15d5c4a2ea42aa5
>
> Diff: https://reviews.apache.org/r/11553/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>