[GitHub] [iceberg] rdblue commented on a diff in pull request #5665: Core: Correctly project the partition fields

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5665:
URL: https://github.com/apache/iceberg/pull/5665#discussion_r960098474


##########
api/src/main/java/org/apache/iceberg/PartitionSpec.java:
##########
@@ -125,8 +125,7 @@ public List<PartitionField> getFieldsBySourceId(int fieldId) {
   public StructType partitionType() {
     List<Types.NestedField> structFields = Lists.newArrayListWithExpectedSize(fields.length);
 
-    for (int i = 0; i < fields.length; i += 1) {
-      PartitionField field = fields[i];
+    for (PartitionField field : fields) {

Review Comment:
   Is it worth modifying an unrelated API file to fix this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org