Re: Review Request 63440: Metrics for OneFS mpack

[Nate Cole <nc...@hortonworks.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63440/#review189803
-----------------------------------------------------------




contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/metrics.json
Lines 6-8 (patched)
<https://reviews.apache.org/r/63440/#comment267011>

    What if https is enabled for OneFS?
    
    Instead isn't there a property that dictates what the url is, regardless of http/https?


- Nate Cole


On Oct. 31, 2017, 12:49 p.m., Attila Magyar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63440/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2017, 12:49 p.m.)
> 
> 
> Review request for Ambari, Nate Cole, Sebastian Toader, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22339
>     https://issues.apache.org/jira/browse/AMBARI-22339
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> OneFS puts its own hostname into the metrics data that is sent to AMS. That hostname is not registered to Ambari therefore AMS host metrics don't show up.
> I added an option to override the default hostname in the metrics.json file.
> 
> 
> For example when a metrics.json has this:
> 
>         "properties" : {
>           "overridden_host" : "${hdfs-site/dfs.namenode.http-address}"
>         },
>         
> Ambari will use this hostname (instead of the component hostname) to assemble the URL that is used to get the metrics data from AMS.        
> 
> for example: http://c6403.ambari.apache.org:6188/ws/v1/timeline/metrics?metricNames=cpu_wio&hostname=<<overridden_hostname>>
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/OverriddenMetricsHostProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java 8c2198b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricHostProvider.java 28e5381 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSComponentPropertyProvider.java 487afde 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java edeb4b7 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/MetricDefinition.java 635ae35 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/OverriddenMetricsHostProviderTest.java PRE-CREATION 
>   contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/metrics.json 335bfba 
>   contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/widgets.json dbde93b 
> 
> 
> Diff: https://reviews.apache.org/r/63440/diff/1/
> 
> 
> Testing
> -------
> 
> - checked ams host and non host metrics through the ui
> 
> 
> existing tests: passed
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>