You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/02 10:23:13 UTC
[GitHub] [airflow] BasPH opened a new pull request #17985: Serialize the template_ext attribute to show it in UI
BasPH opened a new pull request #17985:
URL: https://github.com/apache/airflow/pull/17985
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
closes: https://github.com/apache/airflow/issues/17932
This PR includes `template_ext` as a serialized field. Because `template_ext` is currently not serialized, the task attributes view shows an empty tuple, which is incorrect. With this change, it shows correctly (tuple is converted to list):
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] BasPH commented on pull request #17985: Serialize the template_ext attribute to show it in UI
Posted by GitBox <gi...@apache.org>.
BasPH commented on pull request #17985:
URL: https://github.com/apache/airflow/pull/17985#issuecomment-911557492
Whoops, rebased!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #17985: Serialize the template_ext attribute to show it in UI
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #17985:
URL: https://github.com/apache/airflow/pull/17985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #17985: Serialize the template_ext attribute to show it in UI
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #17985:
URL: https://github.com/apache/airflow/pull/17985#issuecomment-911544503
You need to rebase @BasPH - you are 127 commits behind `main` and we implemented celery >=5 change that conflicts with the old version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17985: Serialize the template_ext attribute to show it in UI
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17985:
URL: https://github.com/apache/airflow/pull/17985#issuecomment-911544503
You need to rebase @BasPH - you are 127 commits behind `main` and we implemented celery >=5 change that conflicts with those
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17985: Serialize the template_ext attribute to show it in UI
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17985:
URL: https://github.com/apache/airflow/pull/17985#issuecomment-911540778
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org