You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/17 21:49:56 UTC

[GitHub] [arrow] davisusanibar commented on a diff in pull request #14422: ARROW-18042: [Java] Distribute Apple M1 compatible JNI libraries via mavencentral

davisusanibar commented on code in PR #14422:
URL: https://github.com/apache/arrow/pull/14422#discussion_r997539117


##########
java/pom.xml:
##########
@@ -1058,7 +1058,7 @@
                     -DCMAKE_BUILD_TYPE=Release
                     -DCMAKE_INSTALL_LIBDIR=lib
                     -DCMAKE_INSTALL_PREFIX=${arrow.dataset.jni.dist.dir}
-                    -DCMAKE_PREFIX_PATH=${project.basedir}/../java-dist
+                    -DCMAKE_PREFIX_PATH=${project.basedir}/../${os.detected.arch}/java-dist

Review Comment:
   Hi Rok, I could suggest that is needed to add `${os.detected.arch}` before all places working with folder `java-dist`
   
   The you could test your changes locally with this maven command please: `mvn generate-resources -Pgenerate-libs-jni-macos-linux -N` inside of `arrow/java` folder ?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org