You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/08 02:29:16 UTC
[GitHub] [arrow] alexdesiqueira opened a new pull request, #13094: [C++][Docs] Fixing cmake calls on docs:developers/cpp/building
alexdesiqueira opened a new pull request, #13094:
URL: https://github.com/apache/arrow/pull/13094
The instructions on [Building Arrow C++ > CMake presets](https://arrow.apache.org/docs/developers/cpp/building.html#cmake-presets) will not run properly on Linux (tested on Debian 11):
```bash
❯ cmake --list-presets
CMake Error: The source directory "/home/alex/projects/arrow/cpp/build/--list-presets" does not exist.
Specify --help for usage, or press the help button on the CMake GUI.
❯ cmake .. --preset ninja-debug-minimal
CMake Error: The source directory "/home/alex/projects/arrow/cpp/build/ninja-debug-minimal" does not exist.
Specify --help for usage, or press the help button on the CMake GUI.
❯ cmake .. --preset ninja-debug-minimal -DCMAKE_INSTALL_PREFIX=/usr/local
CMake Error: The source directory "/home/alex/projects/arrow/cpp/build/ninja-debug-minimal" does not exist.
Specify --help for usage, or press the help button on the CMake GUI.
```
According to cmake,
```bash
❯ cmake --help
Usage
cmake [options] <path-to-source>
cmake [options] <path-to-existing-build>
cmake [options] -S <path-to-source> -B <path-to-build>
```
we would need to define the folder at the end of the command, or explicitly use `-S`. I'm going with the first option here.
@pitrou since this is small change in my mind, I didn't open a ticket on Jira. Please let me know if I'm wrong :slightly_smiling_face:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #13094: MINOR: [C++][Docs] Fixing cmake calls on docs:developers/cpp/building
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #13094:
URL: https://github.com/apache/arrow/pull/13094#issuecomment-1121362489
No problem @alexdesiqueira :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alexdesiqueira commented on pull request #13094: MINOR: [C++][Docs] Fixing cmake calls on docs:developers/cpp/building
Posted by GitBox <gi...@apache.org>.
alexdesiqueira commented on PR #13094:
URL: https://github.com/apache/arrow/pull/13094#issuecomment-1120471495
@pitrou fair enough :joy: I updated cmake to 3.23 using `bullseye-backports` and the commands on [Building Arrow C++ > CMake presets](https://arrow.apache.org/docs/developers/cpp/building.html#cmake-presets) work properly now.
Debian `bullseye` has cmake version 3.18; I missed the part where you say
> Using CMake version 3.21.0 or higher, (...)
Closing. I apologize!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13094: [C++][Docs] Fixing cmake calls on docs:developers/cpp/building
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13094:
URL: https://github.com/apache/arrow/pull/13094#issuecomment-1120336656
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alexdesiqueira closed pull request #13094: MINOR: [C++][Docs] Fixing cmake calls on docs:developers/cpp/building
Posted by GitBox <gi...@apache.org>.
alexdesiqueira closed pull request #13094: MINOR: [C++][Docs] Fixing cmake calls on docs:developers/cpp/building
URL: https://github.com/apache/arrow/pull/13094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #13094: MINOR: [C++][Docs] Fixing cmake calls on docs:developers/cpp/building
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #13094:
URL: https://github.com/apache/arrow/pull/13094#issuecomment-1120385656
@alexdesiqueira Chances are your version of CMake is simply too old?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org