You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@turbine.apache.org by dl...@apache.org on 2001/10/02 01:55:38 UTC

cvs commit: jakarta-turbine-fulcrum/src/core/java/org/apache/fulcrum BaseServiceBroker.java

dlr         01/10/01 16:55:38

  Modified:    src/core/java/org/apache/fulcrum BaseServiceBroker.java
  Log:
  Long line clean up.
  
  Revision  Changes    Path
  1.9       +11 -9     jakarta-turbine-fulcrum/src/core/java/org/apache/fulcrum/BaseServiceBroker.java
  
  Index: BaseServiceBroker.java
  ===================================================================
  RCS file: /home/cvs/jakarta-turbine-fulcrum/src/core/java/org/apache/fulcrum/BaseServiceBroker.java,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -u -r1.8 -r1.9
  --- BaseServiceBroker.java	2001/09/03 17:19:23	1.8
  +++ BaseServiceBroker.java	2001/10/01 23:55:38	1.9
  @@ -67,6 +67,7 @@
   import org.apache.fulcrum.ServiceException;
   import org.apache.commons.collections.ExtendedProperties;
   import org.apache.log4j.Category;
  +import org.apache.log4j.helpers.NullEnumeration
   
   // NOTE:
   // initClass is taking the name of the service now not
  @@ -92,7 +93,7 @@
    * @author <a href="mailto:krzewski@e-point.pl">Rafal Krzewski</a>
    * @author <a href="mailto:dlr@finemaltcoding.com">Daniel Rall</a>
    * @author <a href="mailto:jvanzyl@apache.org">Jason van Zyl</a>
  - * @version $Id: BaseServiceBroker.java,v 1.8 2001/09/03 17:19:23 jvanzyl Exp $
  + * @version $Id: BaseServiceBroker.java,v 1.9 2001/10/01 23:55:38 dlr Exp $
    */
   public abstract class BaseServiceBroker 
       implements ServiceBroker
  @@ -170,22 +171,23 @@
       /**
        * Determine whether log4j has already been configured.
        *
  -     * @return boolean is log4j configured
  +     * @return boolean Whether log4j is configured.
        */
       protected boolean isLoggingConfigured() 
       {
           // This is a note from Ceki, taken from a message on the log4j
           // user list:
           //
  -        // Having defined categories does not necessarily mean configuration. 
  -        // Remember that most categories are created outside the configuration file. 
  -        // What you want to check for is the existence of appenders. The correct 
  -        // procedure is to first check for appenders in the root category and if that 
  -        // returns no appenders to check in other categories. 
  +        // Having defined categories does not necessarily mean
  +        // configuration. Remember that most categories are created
  +        // outside the configuration file. What you want to check for
  +        // is the existence of appenders. The correct procedure is to
  +        // first check for appenders in the root category and if that
  +        // returns no appenders to check in other categories.
           
           Enumeration enum = Category.getRoot().getAllAppenders();
                
  -        if(!(enum instanceof org.apache.log4j.helpers.NullEnumeration))
  +        if (!(enum instanceof NullEnumeration))
           {
               return true;
           } 
  @@ -195,7 +197,7 @@
               while(cats.hasMoreElements()) 
               {
                   Category c = (Category) cats.nextElement();
  -                if(!(c.getAllAppenders() instanceof org.apache.log4j.helpers.NullEnumeration))
  +                if (!(c.getAllAppenders() instanceof NullEnumeration))
                   {
                       return true;
                   }                     
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org