You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/16 23:46:28 UTC
[GitHub] [airflow] cris-b opened a new pull request #13121: Fix https://github.com/apache/airflow/issues/12669
cris-b opened a new pull request #13121:
URL: https://github.com/apache/airflow/pull/13121
Fix error in case of changing permissions a log file on a filesystem which does not implement chmod/chown (azure files/azure blob/samba etc)
A warning will now be logged.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: 12669
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #13121: Fix permission error on non-POSIX filesystem
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #13121:
URL: https://github.com/apache/airflow/pull/13121
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13121: Fix permission error on non-POSIX filesystem
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13121:
URL: https://github.com/apache/airflow/pull/13121#issuecomment-747401774
Some static checks are failing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13121: Fix permission error on non-POSIX filesystem
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13121:
URL: https://github.com/apache/airflow/pull/13121#issuecomment-773944631
[The Workflow run](https://github.com/apache/airflow/actions/runs/539893935) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] cris-b commented on pull request #13121: Fix permission error on non-POSIX filesystem
Posted by GitBox <gi...@apache.org>.
cris-b commented on pull request #13121:
URL: https://github.com/apache/airflow/pull/13121#issuecomment-784114603
@potiuk - thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13121: Fix permission error on non-POSIX filesystem
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13121:
URL: https://github.com/apache/airflow/pull/13121#issuecomment-781715509
[The Workflow run](https://github.com/apache/airflow/actions/runs/579770326) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] cris-b commented on pull request #13121: Fix permission error on non-POSIX filesystem
Posted by GitBox <gi...@apache.org>.
cris-b commented on pull request #13121:
URL: https://github.com/apache/airflow/pull/13121#issuecomment-781718340
not sure where the pylint error is in my code from those logs..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] cris-b commented on pull request #13121: Fix permission error on non-POSIX filesystem
Posted by GitBox <gi...@apache.org>.
cris-b commented on pull request #13121:
URL: https://github.com/apache/airflow/pull/13121#issuecomment-784110044
@potiuk ok giving up on the CI now, it fails in a different way each time, seemingly unrelated to the code change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13121: Fix permission error on non-POSIX filesystem
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13121:
URL: https://github.com/apache/airflow/pull/13121#issuecomment-782851846
[The Workflow run](https://github.com/apache/airflow/actions/runs/586356657) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13121: Fix permission error on non-POSIX filesystem
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13121:
URL: https://github.com/apache/airflow/pull/13121#issuecomment-747122362
[The Workflow run](https://github.com/apache/airflow/actions/runs/426881704) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13121: Fix permission error on non-POSIX filesystem
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13121:
URL: https://github.com/apache/airflow/pull/13121#issuecomment-781715272
[The Workflow run](https://github.com/apache/airflow/actions/runs/579767647) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] cris-b commented on pull request #13121: Fix permission error on non-POSIX filesystem
Posted by GitBox <gi...@apache.org>.
cris-b commented on pull request #13121:
URL: https://github.com/apache/airflow/pull/13121#issuecomment-782845475
Thanks that fixed it but it failed later with no logs.. Frustrating
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13121: Fix permission error on non-POSIX filesystem
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13121:
URL: https://github.com/apache/airflow/pull/13121#issuecomment-782619084
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13121: Fix https://github.com/apache/airflow/issues/12669
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13121:
URL: https://github.com/apache/airflow/pull/13121#issuecomment-747115881
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13121: Fix permission error on non-POSIX filesystem
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13121:
URL: https://github.com/apache/airflow/pull/13121#issuecomment-784111357
Yep. It was intermittent failure. Merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13121: Fix permission error on non-POSIX filesystem
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13121:
URL: https://github.com/apache/airflow/pull/13121#issuecomment-782663381
We are looking at the pylint failures - it's pretty strange - several other PRs have similar problems but it's still not clear why. However I attempted to improve the static checks approach here: https://github.com/apache/airflow/pull/14332 - one of the changes there is to sort the files for pylint in determinstic way, my hypothesis is that the sequence order of files might have caused those pylint errors. I will try to merge it quickly and once it's done I will ask you to rebase and see if this fixed the problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] cris-b commented on pull request #13121: Fix permission error on non-POSIX filesystem
Posted by GitBox <gi...@apache.org>.
cris-b commented on pull request #13121:
URL: https://github.com/apache/airflow/pull/13121#issuecomment-782617506
am i missing something here? why is pylint failing but not on my changes? I can see other PRs passing pylint...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13121: Fix permission error on non-POSIX filesystem
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13121:
URL: https://github.com/apache/airflow/pull/13121#issuecomment-784111469
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13121: Fix https://github.com/apache/airflow/issues/12669
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13121:
URL: https://github.com/apache/airflow/pull/13121#issuecomment-747108446
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org