[GitHub] [incubator-superset] rusackas commented on a change in pull request #11458: chore: enabled cypress test in filter file

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #11458:
URL: https://github.com/apache/incubator-superset/pull/11458#discussion_r513617249



##########
File path: superset-frontend/cypress-base/cypress/integration/dashboard/filter.test.ts
##########
@@ -101,16 +101,19 @@ describe('Dashboard filter', () => {
     cy.get('.filter_box button').click({ force: true });
 
     // wait again after applied filters
-    cy.wait(aliases.filter(x => x !== getAlias(filterId))).then(requests => {
+    cy.wait(
+      aliases.filter(x => x !== getAlias(filterId)),
+      { timeout: 30000 },

Review comment:
       This seems like a reeeeeally long timeout. Is there a reason for this? If so, maybe add a comment to the code so people don't follow the pattern here unnecessarily, and potentially slow down a hundred failing tests by 30 seconds each ;)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org