You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2021/02/25 10:49:12 UTC

[GitHub] [httpcomponents-core] arturobernalg commented on a change in pull request #267: HTTPCORE-670 - Add new headers

arturobernalg commented on a change in pull request #267:
URL: https://github.com/apache/httpcomponents-core/pull/267#discussion_r582733294



##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/HttpHeaders.java
##########
@@ -130,6 +188,17 @@ private HttpHeaders() {
 
     public static final String STATUS_URI = "Status-URI";
 
+    /**
+     * The HTTP {@code Set-Cookie} header field name.
+     * @see <a href="https://tools.ietf.org/html/rfc2109#section-4.2.2">Section 4.2.2 of RFC 2109</a>
+     */
+    public static final String SET_COOKIE = "Set-Cookie";
+    /**
+     * The HTTP {@code Set-Cookie2} header field name.
+     * @see <a href="https://tools.ietf.org/html/rfc2965">RFC 2965</a>
+     */
+    public static final String SET_COOKIE2 = "Set-Cookie2";

Review comment:
       Agree, changed 

##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/HttpHeaders.java
##########
@@ -130,6 +188,17 @@ private HttpHeaders() {
 
     public static final String STATUS_URI = "Status-URI";
 
+    /**
+     * The HTTP {@code Set-Cookie} header field name.
+     * @see <a href="https://tools.ietf.org/html/rfc2109#section-4.2.2">Section 4.2.2 of RFC 2109</a>

Review comment:
       Agree, changed 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org