[GitHub] [accumulo] milleruntime commented on a change in pull request #1551: Use sets instead of arrays for volumes

[GitBox <gi...@apache.org>]

milleruntime commented on a change in pull request #1551: Use sets instead of arrays for volumes
URL: https://github.com/apache/accumulo/pull/1551#discussion_r388956871
 
 

 ##########
 File path: server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java
 ##########
 @@ -385,10 +385,10 @@ public boolean isReady() throws IOException {
   }
 
   @Override
-  public Path matchingFileSystem(Path source, String[] options) {
+  public Path matchingFileSystem(Path source, Set<String> options) {
     try {
       if (ViewFSUtils.isViewFS(source, hadoopConf)) {
-        return ViewFSUtils.matchingFileSystem(source, options, hadoopConf);
+        return ViewFSUtils.matchingFileSystem(source, options.toArray(new String[0]), hadoopConf);
 
 Review comment:
   Could make ```ViewFSUtils``` take a Set as well.  Looks like this is the only class that uses it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services