You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@quickstep.apache.org by zuyu <gi...@git.apache.org> on 2017/01/16 02:34:19 UTC
[GitHub] incubator-quickstep pull request #161: Removed the unused feedInputBlocks.
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/161
Removed the unused feedInputBlocks.
Assigned to @hbdeshmukh.
This small PR removed the unused `feedInputBlocks` in `RelationalOperator`s for passing partially filled blocks to the operator.
Even worse, there is a follow-up PR that adds `partition_id` in `feedInputBlock`, the existing `feedInputBlocks` would be hard to adapt w/ partition info.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-quickstep remove-feedInputBlocks
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quickstep/pull/161.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #161
----
commit 3fe592cf7a8d3e9cb8f3858f19b88b84c7fceb38
Author: Zuyu Zhang <zu...@apache.org>
Date: 2017-01-16T02:09:03Z
Removed the unused feedInputBlocks.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #161: Removed the unused feedInputBlocks.
Posted by hbdeshmukh <gi...@git.apache.org>.
Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/161#discussion_r96273055
--- Diff: relational_operators/NestedLoopsJoinOperator.hpp ---
@@ -141,9 +141,16 @@ class NestedLoopsJoinOperator : public RelationalOperator {
}
}
- void feedInputBlock(const block_id input_block_id, const relation_id input_relation_id) override;
-
- void feedInputBlocks(const relation_id rel_id, std::vector<block_id> *partially_filled_blocks) override;
+ void feedInputBlock(const block_id input_block_id, const relation_id input_relation_id) override {
+ if (input_relation_id == left_input_relation_.getID()) {
+ left_relation_block_ids_.push_back(input_block_id);
+ } else if (input_relation_id == right_input_relation_.getID()) {
+ right_relation_block_ids_.push_back(input_block_id);
+ } else {
+ FATAL_ERROR("The input block sent to the NestedLoopsJoinOperator belongs "
--- End diff --
While we are at it, would you mind changing the FATAL_ERROR to GLOG style error?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #161: Removed the unused feedInputBlocks.
Posted by hbdeshmukh <gi...@git.apache.org>.
Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/161
Looks good to me, will merge after you go through the comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #161: Removed the unused feedInputBlocks.
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/161#discussion_r96274584
--- Diff: relational_operators/NestedLoopsJoinOperator.hpp ---
@@ -141,9 +141,16 @@ class NestedLoopsJoinOperator : public RelationalOperator {
}
}
- void feedInputBlock(const block_id input_block_id, const relation_id input_relation_id) override;
-
- void feedInputBlocks(const relation_id rel_id, std::vector<block_id> *partially_filled_blocks) override;
+ void feedInputBlock(const block_id input_block_id, const relation_id input_relation_id) override {
+ if (input_relation_id == left_input_relation_.getID()) {
+ left_relation_block_ids_.push_back(input_block_id);
+ } else if (input_relation_id == right_input_relation_.getID()) {
+ right_relation_block_ids_.push_back(input_block_id);
+ } else {
+ FATAL_ERROR("The input block sent to the NestedLoopsJoinOperator belongs "
--- End diff --
Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #161: Removed the unused feedInputBlocks.
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/161
There is a `NetworkUtil_unittest` test failure, but it is not related to this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #161: Removed the unused feedInputBlocks.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/161
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---