[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a change in pull request #1092: trace: fix pointer cross the border

[GitBox <gi...@apache.org>]

pkarashchenko commented on a change in pull request #1092:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1092#discussion_r836177622



##########
File path: system/trace/trace.c
##########
@@ -735,29 +738,32 @@ static int trace_cmd_print(int index, int argc, FAR char **argv,
 
   /* Parse the setting parameters */
 
-  if (argv[index][0] == '-' || argv[index][0] == '+')
+  while (index < argc)

Review comment:
       ```suggestion
     if (index < argc)
   ```

##########
File path: system/trace/trace.c
##########
@@ -485,29 +485,32 @@ static int trace_cmd_switch(int index, int argc, FAR char **argv,
 
   /* Parse the setting parameters */
 
-  if (argv[index][0] == '-' || argv[index][0] == '+')
+  while (index < argc)

Review comment:
       ```suggestion
     if (index < argc)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org