You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/02/17 03:09:21 UTC
[GitHub] [calcite] danny0405 commented on a change in pull request #1807:
[CALCITE-3796] Support Array operator <, <=, >, >=
danny0405 commented on a change in pull request #1807: [CALCITE-3796] Support Array operator <, <=, >, >=
URL: https://github.com/apache/calcite/pull/1807#discussion_r379969482
##########
File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java
##########
@@ -693,6 +693,22 @@ public static boolean lt(BigDecimal b0, BigDecimal b1) {
return b0.compareTo(b1) < 0;
}
+ /** SQL <code><</code> operator applied to List<Comparable> values. */
+ public static <T extends Comparable> boolean lt(List<T> b0, List<T> b1) {
+ for (int i = 0; i < b0.size(); i++) {
+ // b0 is greater because b0 is longer than b1.
Review comment:
From your changes, it seems that the array comparison is allowed in the logic layer, we just do not have a right implementation ~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services