[GitHub] arina-ielchiieva commented on a change in pull request #1450: DRILL-6717: lower and upper functions not works with national characters

[GitBox <gi...@apache.org>]

arina-ielchiieva commented on a change in pull request #1450: DRILL-6717: lower and upper functions not works with national characters
URL: https://github.com/apache/drill/pull/1450#discussion_r213611869
 
 

 ##########
 File path: exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/impl/TestStringFunctions.java
 ##########
 @@ -1441,11 +1442,12 @@ public void testUpper() throws Exception {
             "upper('AbC aBc') as col_space,\n" +
             "upper('123ABC$!abc123.') as col_special,\n" +
             "upper('') as col_empty,\n" +
-            "upper(cast(null as varchar(10))) as col_null\n" +
+            "upper(cast(null as varchar(10))) as col_null,\n" +
+            "upper('привет, мир!') as col_national\n" +
 
 Review comment:
   @oleg-zinovev there ignored unit test tow tests below (https://github.com/apache/drill/pull/1450/files#diff-01e4581e7fc41d7bc289363e5d7ab661L1471), just enable it and it should cover the use cases.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services