You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ignite.apache.org by Saikat Maitra <sa...@gmail.com> on 2020/04/26 17:40:08 UTC

IGNITE-12357 Migrate Twitter module to ignite-extensions

Hi,

I have raised PRs for migration of twitter module in ignite-extensions
repository.

Jira
https://issues.apache.org/jira/browse/IGNITE-12357

PRs
https://github.com/apache/ignite-extensions/pull/12
https://github.com/apache/ignite/pull/7733

Please review and share your feedback.

Regards,
Saikat

Re: IGNITE-12357 Migrate Twitter module to ignite-extensions

Posted by Saikat Maitra <sa...@gmail.com>.

Thank you Denis for reviewing the changes.

Regards,
Saikat

On Wed, Apr 29, 2020 at 1:24 PM Denis Magda <dm...@apache.org> wrote:

> Saikat, please go ahead and merge the changes. They look good to me.
>
> -
> Denis
>
>
> On Mon, Apr 27, 2020 at 4:09 PM Saikat Maitra <sa...@gmail.com>
> wrote:
>
> > Hi Petr,
> >
> > Yes, I have created an issue to update TC configuration once changes are
> > merged.
> >
> > https://issues.apache.org/jira/browse/IGNITE-12960
> >
> > Please let me know if the PR changes looks good.
> >
> > Regards,
> > Saikat
> >
> >
> > On Mon, Apr 27, 2020 at 1:39 AM Petr Ivanov <mr...@gmail.com> wrote:
> >
> > > Please, remember to update TC configuration or create issue to do that.
> > >
> > >
> > > > On 26 Apr 2020, at 20:40, Saikat Maitra <sa...@gmail.com>
> > wrote:
> > > >
> > > > Hi,
> > > >
> > > > I have raised PRs for migration of twitter module in
> ignite-extensions
> > > > repository.
> > > >
> > > > Jira
> > > > https://issues.apache.org/jira/browse/IGNITE-12357
> > > >
> > > > PRs
> > > > https://github.com/apache/ignite-extensions/pull/12
> > > > https://github.com/apache/ignite/pull/7733
> > > >
> > > > Please review and share your feedback.
> > > >
> > > > Regards,
> > > > Saikat
> > >
> > >
> >
>

Re: IGNITE-12357 Migrate Twitter module to ignite-extensions

Posted by Denis Magda <dm...@apache.org>.

Saikat, please go ahead and merge the changes. They look good to me.

-
Denis


On Mon, Apr 27, 2020 at 4:09 PM Saikat Maitra <sa...@gmail.com>
wrote:

> Hi Petr,
>
> Yes, I have created an issue to update TC configuration once changes are
> merged.
>
> https://issues.apache.org/jira/browse/IGNITE-12960
>
> Please let me know if the PR changes looks good.
>
> Regards,
> Saikat
>
>
> On Mon, Apr 27, 2020 at 1:39 AM Petr Ivanov <mr...@gmail.com> wrote:
>
> > Please, remember to update TC configuration or create issue to do that.
> >
> >
> > > On 26 Apr 2020, at 20:40, Saikat Maitra <sa...@gmail.com>
> wrote:
> > >
> > > Hi,
> > >
> > > I have raised PRs for migration of twitter module in ignite-extensions
> > > repository.
> > >
> > > Jira
> > > https://issues.apache.org/jira/browse/IGNITE-12357
> > >
> > > PRs
> > > https://github.com/apache/ignite-extensions/pull/12
> > > https://github.com/apache/ignite/pull/7733
> > >
> > > Please review and share your feedback.
> > >
> > > Regards,
> > > Saikat
> >
> >
>

Re: IGNITE-12357 Migrate Twitter module to ignite-extensions

Posted by Saikat Maitra <sa...@gmail.com>.

Hi Petr,

Yes, I have created an issue to update TC configuration once changes are
merged.

https://issues.apache.org/jira/browse/IGNITE-12960

Please let me know if the PR changes looks good.

Regards,
Saikat


On Mon, Apr 27, 2020 at 1:39 AM Petr Ivanov <mr...@gmail.com> wrote:

> Please, remember to update TC configuration or create issue to do that.
>
>
> > On 26 Apr 2020, at 20:40, Saikat Maitra <sa...@gmail.com> wrote:
> >
> > Hi,
> >
> > I have raised PRs for migration of twitter module in ignite-extensions
> > repository.
> >
> > Jira
> > https://issues.apache.org/jira/browse/IGNITE-12357
> >
> > PRs
> > https://github.com/apache/ignite-extensions/pull/12
> > https://github.com/apache/ignite/pull/7733
> >
> > Please review and share your feedback.
> >
> > Regards,
> > Saikat
>
>

Re: IGNITE-12357 Migrate Twitter module to ignite-extensions

Posted by Petr Ivanov <mr...@gmail.com>.

Please, remember to update TC configuration or create issue to do that.


> On 26 Apr 2020, at 20:40, Saikat Maitra <sa...@gmail.com> wrote:
> 
> Hi,
> 
> I have raised PRs for migration of twitter module in ignite-extensions
> repository.
> 
> Jira
> https://issues.apache.org/jira/browse/IGNITE-12357
> 
> PRs
> https://github.com/apache/ignite-extensions/pull/12
> https://github.com/apache/ignite/pull/7733
> 
> Please review and share your feedback.
> 
> Regards,
> Saikat