You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@groovy.apache.org by PascalSchumacher <gi...@git.apache.org> on 2015/10/06 10:08:42 UTC

[GitHub] incubator-groovy pull request: [GROOVY-6854] JsonOutput should be ...

Github user PascalSchumacher commented on a diff in the pull request:

    https://github.com/apache/incubator-groovy/pull/124#discussion_r41235241
  
    --- Diff: subprojects/groovy-json/src/main/java/groovy/json/JsonOutput.java ---
    @@ -61,7 +61,8 @@
         private static final String NULL_VALUE = "null";
         private static final String JSON_DATE_FORMAT = "yyyy-MM-dd'T'HH:mm:ssZ";
         private static final String DEFAULT_TIMEZONE = "GMT";
    -
    +    private static final SimpleDateFormat dateFormat = new SimpleDateFormat(JSON_DATE_FORMAT);
    --- End diff --
    
    SimpleDateFormat is not thread-safe (see http://stackoverflow.com/questions/6840803/simpledateformat-thread-safety for an explanation)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---