You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "David Smiley (Jira)" <ji...@apache.org> on 2020/07/31 17:56:00 UTC
[jira] [Comment Edited] (SOLR-14675) [SolrJ] Http2SolrClient async
request through CloudHttp2SolrClient
[ https://issues.apache.org/jira/browse/SOLR-14675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17169046#comment-17169046 ]
David Smiley edited comment on SOLR-14675 at 7/31/20, 5:55 PM:
---------------------------------------------------------------
I propose we back up a second and come at this first from a requirements standpoint. The low level details are interesting but possibly distracting us on what users would find useful. The API was established in SOLR-14354 "HttpShardHandler send requests in async" _very_ recently which introduced {{Http2SolrClient.asyncRequest}} but I'd like to debate that API signature while the paint is wet, and I ought to do so on SOLR-14354 so I'll do that now (FYI "watch" it if you are interested). For _this_ issue, I suppose the high level problem is that CloudHttp2SolrClient does not implement the same method "asyncRequest" as these are on two separate branches of the SolrClient hierarchy. Perhaps SolrClient itself ought to have "asyncRequest" with a default implementation that is synchronous or maybe throws UnsupportedOperationException (depends on one's point of view I suppose) or maybe uses an executor with a trivial implementation.
was (Author: dsmiley):
I propose we back up a second and come at this first from a requirements standpoint. The low level details are interesting but possibly distracting us on what users would find useful. The API was established in SOLR-14354 "HttpShardHandler send requests in async" _very_ recently which introduced {{Http2SolrClient.asyncRequest}} but I'd like to debate that API signature while the pain is wet, and I ought to do so on SOLR-14354 so I'll do that now (FYI "watch" it if you are interested). For _this_ issue, I suppose the high level problem is that CloudHttp2SolrClient does not implement the same method "asyncRequest" as these are on two separate branches of the SolrClient hierarchy. Perhaps SolrClient itself ought to have "asyncRequest" with a default implementation that is synchronous or maybe throws UnsupportedOperationException (depends on one's point of view I suppose) or maybe uses an executor with a trivial implementation.
> [SolrJ] Http2SolrClient async request through CloudHttp2SolrClient
> ------------------------------------------------------------------
>
> Key: SOLR-14675
> URL: https://issues.apache.org/jira/browse/SOLR-14675
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrJ
> Affects Versions: 8.7
> Reporter: Rishi Sankar
> Priority: Minor
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> In Solr 8.7, org.apache.solr.client.solrj.impl.Http2SolrClient has an asyncRequest method which supports making async requests with a callback parameter. However, this method is only used internally by the MockingHttp2SolrClient and LBHttp2SolrClient. I'd like to contribute a method to the CloudHttp2SolrClient that allows for making an asynchronous request with a callback parameter that can be passed down to the Http2SolrClient asyncRequest call.
> I've been coordinating with [~dsmiley] about making this change.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org