[GitHub] [samza] cameronlee314 commented on a change in pull request #954: SAMZA-2129: Move the offset comparison check to choose the lowest offset to SystemConsumers.

[GitBox <gi...@apache.org>]

cameronlee314 commented on a change in pull request #954: SAMZA-2129: Move the offset comparison check to choose the lowest offset to SystemConsumers.
URL: https://github.com/apache/samza/pull/954#discussion_r266562517
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/system/SystemAdmins.java
 ##########
 @@ -38,6 +38,10 @@ public SystemAdmins(Config config) {
     this.systemAdminMap = systemConfig.getSystemAdmins();
   }
 
+  public SystemAdmins(Map<String, SystemAdmin> systemAdminMap) {
 
 Review comment:
   Is this only for tests? Could you mock it instead in the tests? It would be good to avoid having public methods just for tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services