[jira] [Commented] (CB-10039) Problem add Contact photos from relative and absolute path for Android

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-10039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034970#comment-15034970 ] 

ASF GitHub Bot commented on CB-10039:
-------------------------------------

Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/94#discussion_r46362158
  
    --- Diff: src/android/ContactAccessorSdk5.java ---
    @@ -1631,24 +1631,41 @@ private void insertPhoto(ArrayList<ContentProviderOperation> ops,
         }
     
         /**
    -       * Get an input stream based on file path or uri content://, http://, file://
    -       *
    -       * @param path
    -       * @return an input stream
    +     * Get an input stream based on file path or uri content://, http://, file://
    +     *
    +     * @param path path to file
    +     * @return an input stream
          * @throws IOException
    -       */
    +     */
         private InputStream getPathFromUri(String path) throws IOException {
    +        String ASSET_PREFIX = "file:///android_asset/";
    --- End diff --
    
    Please set this as a constant at the top, similarly to `EMAIL_REGEXP ` and `MAX_PHOTO_SIZE `.


> Problem add Contact photos from relative and absolute path for Android
> ----------------------------------------------------------------------
>
>                 Key: CB-10039
>                 URL: https://issues.apache.org/jira/browse/CB-10039
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Contacts
>         Environment: Android
>            Reporter: vincipop
>            Assignee: Vladimir Kotikov
>            Priority: Minor
>              Labels: Android
>             Fix For: Master
>
>
> problem add Contact photos from relative and absolute path for Android: Get input stream from relative and full path in ContactAccessorSdk.java
> Solved, attempt to merge on Github.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org