You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cdkrot (via GitHub)" <gi...@apache.org> on 2023/10/04 11:55:15 UTC
[PR] [SPARK-45394][PYTHON][CONNECT] Add retries for artifact API. Improve error handling (follow-up to [SPARK-45093]). [spark]
cdkrot opened a new pull request, #43216:
URL: https://github.com/apache/spark/pull/43216
### What changes were proposed in this pull request?
Add retries to `add_artifact` api in client
Slightly change control flow within `artifact.py` so that client-side errors (e.g. FileNotFound) are properly thrown. (Previously we attempted to add logs in https://github.com/apache/spark/pull/42949, but that was imperfect solution, this should be much better).
### Why are the changes needed?
Improves user experience
### Does this PR introduce _any_ user-facing change?
Improve error handling, adds retries.
### How was this patch tested?
Added test coverage for add_artifact when there is no artifact.
### Was this patch authored or co-authored using generative AI tooling?
NO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45394][PYTHON][CONNECT] Add retries for artifact API. Improve error handling (follow-up to [SPARK-45093]). [spark]
Posted by "cdkrot (via GitHub)" <gi...@apache.org>.
cdkrot commented on PR #43216:
URL: https://github.com/apache/spark/pull/43216#issuecomment-1746725358
cc @HyukjinKwon, @grundprinzip, PTAL
cc @allisonwang-db --- thank you for leaving feedback under original Pr: https://github.com/apache/spark/pull/42949. I think this is much better version than it was back then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45394][PYTHON][CONNECT] Add retries for artifact API. Improve error handling (follow-up to [SPARK-45093]). [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #43216: [SPARK-45394][PYTHON][CONNECT] Add retries for artifact API. Improve error handling (follow-up to [SPARK-45093]).
URL: https://github.com/apache/spark/pull/43216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45394][PYTHON][CONNECT] Add retries for artifact API. Improve error handling (follow-up to [SPARK-45093]). [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43216:
URL: https://github.com/apache/spark/pull/43216#issuecomment-1749896033
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org