You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2015/01/19 16:01:24 UTC
Review Request 30031: Views: min and max version
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30031/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley and Nate Cole.
Bugs: AMBARI-9133
https://issues.apache.org/jira/browse/AMBARI-9133
Repository: ambari
Description
-------
Add support for including optional min, max or min+max Ambari version in view.xml. This can include exact versions or variables. A few examples:
<minVersion>1.7.0</minVersion>
<minVersion>1.7.*</minVersion>
<maxVersion>1.*</maxVersion>
On deploy, ambari should validate the view meets the min/max specified and if not, not deploy and produce an error in the log with the details (for example: "view requires minimum ambari version 1.7")
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewVersionResourceProvider.java 58cf774
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java 2f83e02
ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 05f9ce1
ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java ea04a21
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java b9e56ee
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProviderTest.java e1a4da3
ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewEntityTest.java f93403d
ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 203ea18
ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java 50a1223
ambari-views/src/main/resources/view.xsd f4d65c4
Diff: https://reviews.apache.org/r/30031/diff/
Testing
-------
Manual testing.
New unit tests added. All existing tests pass...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 29:00 min
[INFO] Finished at: 2015-01-19T09:12:23-05:00
[INFO] Final Memory: 44M/646M
[INFO] ------------------------------------------------------------------------
Thanks,
Tom Beerbower
Re: Review Request 30031: Views: min and max version
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30031/#review68652
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Jan. 19, 2015, 10:01 a.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30031/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2015, 10:01 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-9133
> https://issues.apache.org/jira/browse/AMBARI-9133
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add support for including optional min, max or min+max Ambari version in view.xml. This can include exact versions or variables. A few examples:
>
> <minVersion>1.7.0</minVersion>
> <minVersion>1.7.*</minVersion>
> <maxVersion>1.*</maxVersion>
>
> On deploy, ambari should validate the view meets the min/max specified and if not, not deploy and produce an error in the log with the details (for example: "view requires minimum ambari version 1.7")
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewVersionResourceProvider.java 58cf774
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java 2f83e02
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 05f9ce1
> ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java ea04a21
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java b9e56ee
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProviderTest.java e1a4da3
> ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewEntityTest.java f93403d
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 203ea18
> ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java 50a1223
> ambari-views/src/main/resources/view.xsd f4d65c4
>
> Diff: https://reviews.apache.org/r/30031/diff/
>
>
> Testing
> -------
>
> Manual testing.
>
> New unit tests added. All existing tests pass...
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 29:00 min
> [INFO] Finished at: 2015-01-19T09:12:23-05:00
> [INFO] Final Memory: 44M/646M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 30031: Views: min and max version
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30031/#review68656
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Jan. 19, 2015, 10:01 a.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30031/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2015, 10:01 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-9133
> https://issues.apache.org/jira/browse/AMBARI-9133
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add support for including optional min, max or min+max Ambari version in view.xml. This can include exact versions or variables. A few examples:
>
> <minVersion>1.7.0</minVersion>
> <minVersion>1.7.*</minVersion>
> <maxVersion>1.*</maxVersion>
>
> On deploy, ambari should validate the view meets the min/max specified and if not, not deploy and produce an error in the log with the details (for example: "view requires minimum ambari version 1.7")
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewVersionResourceProvider.java 58cf774
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java 2f83e02
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 05f9ce1
> ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java ea04a21
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java b9e56ee
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProviderTest.java e1a4da3
> ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewEntityTest.java f93403d
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 203ea18
> ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java 50a1223
> ambari-views/src/main/resources/view.xsd f4d65c4
>
> Diff: https://reviews.apache.org/r/30031/diff/
>
>
> Testing
> -------
>
> Manual testing.
>
> New unit tests added. All existing tests pass...
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 29:00 min
> [INFO] Finished at: 2015-01-19T09:12:23-05:00
> [INFO] Final Memory: 44M/646M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>