[GitHub] [accumulo] dlmarion commented on a diff in pull request #3569: ensures sessions are always cleaned up

["dlmarion (via GitHub)" <gi...@apache.org>]

dlmarion commented on code in PR #3569:
URL: https://github.com/apache/accumulo/pull/3569#discussion_r1255751666


##########
server/tserver/src/main/java/org/apache/accumulo/tserver/session/SessionManager.java:
##########
@@ -61,7 +63,7 @@ public class SessionManager {
   private final ConcurrentMap<Long,Session> sessions = new ConcurrentHashMap<>();
   private final long maxIdle;
   private final long maxUpdateIdle;
-  private final List<Session> idleSessions = new ArrayList<>();
+  private final BlockingQueue<Session> deferredCleanupQueue = new LinkedBlockingQueue<>();

Review Comment:
   This is unbounded. Do we want to add some logging when the size of this queue crosses some threshold. I'm thinking of something like printing a warning for every 100 sessions or something.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org