You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/07/30 23:13:39 UTC
[GitHub] [trafficserver] bneradt opened a new pull request #7071: Draft: Adding autopep8 as a pre-commit hook.
bneradt opened a new pull request #7071:
URL: https://github.com/apache/trafficserver/pull/7071
This works locally. Feel free to leave feedback, but in the meantime I'll send an email to the dev mailing list to confirm that the community feels comfortable adding this to our pre-commit hook.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #7071: Adding autopep8 as a pre-commit hook.
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #7071:
URL: https://github.com/apache/trafficserver/pull/7071#issuecomment-672070478
[approve ci docs]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #7071: Adding autopep8 as a pre-commit hook.
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7071:
URL: https://github.com/apache/trafficserver/pull/7071#issuecomment-670611815
[approve ci]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #7071: Adding autopep8 as a pre-commit hook.
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7071:
URL: https://github.com/apache/trafficserver/pull/7071#issuecomment-687221155
Cherry-picked to v9.0.x branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #7071: Adding autopep8 as a pre-commit hook.
Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #7071:
URL: https://github.com/apache/trafficserver/pull/7071#issuecomment-670198974
I removed the draft status on this since the community seems interested in getting this hook integrated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #7071: Adding autopep8 as a pre-commit hook.
Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #7071:
URL: https://github.com/apache/trafficserver/pull/7071#issuecomment-675798473
This would be helpful to backport to 9.0.x.
### Backport Rationale
If we do not backport, people will face an annoyance if they transition from master branch back to 9.0.x branch locally. Until they perform a make or make install, they will have the master's version of the .git/hooks/pre-commit hook which will try to reference tools/autopep8.sh which will no longer exist in the 9.0.x branch. The solution will be to perform a make install which will correct the .git/hooks/pre-commit hook, but if they don't they'll be confused as to why their pre-commit hook doesn't work when it says it cannot access tools/autopep8.sh.
I assume this happened when we first introduced tools/clang-format.sh as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall merged pull request #7071: Adding autopep8 as a pre-commit hook.
Posted by GitBox <gi...@apache.org>.
bryancall merged pull request #7071:
URL: https://github.com/apache/trafficserver/pull/7071
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org