You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by se...@apache.org on 2018/07/15 22:23:44 UTC
[2/6] flink git commit: [hotfix] [core] Fix checkstyle in
flink-core:'org.apache.flink.api.common.io.compression'
[hotfix] [core] Fix checkstyle in flink-core:'org.apache.flink.api.common.io.compression'
Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/548e9ed5
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/548e9ed5
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/548e9ed5
Branch: refs/heads/master
Commit: 548e9ed55efaf9eb22c5f3031558f0371df0d08c
Parents: 695bc56
Author: Stephan Ewen <se...@apache.org>
Authored: Fri Jul 13 15:23:38 2018 +0200
Committer: Stephan Ewen <se...@apache.org>
Committed: Sun Jul 15 23:18:56 2018 +0200
----------------------------------------------------------------------
.../common/io/compression/Bzip2InputStreamFactory.java | 13 +++++++------
.../compression/DeflateInflaterInputStreamFactory.java | 6 ++----
.../io/compression/GzipInflaterInputStreamFactory.java | 7 +++----
.../common/io/compression/XZInputStreamFactory.java | 12 +++++++-----
4 files changed, 19 insertions(+), 19 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flink/blob/548e9ed5/flink-core/src/main/java/org/apache/flink/api/common/io/compression/Bzip2InputStreamFactory.java
----------------------------------------------------------------------
diff --git a/flink-core/src/main/java/org/apache/flink/api/common/io/compression/Bzip2InputStreamFactory.java b/flink-core/src/main/java/org/apache/flink/api/common/io/compression/Bzip2InputStreamFactory.java
index d204907..a1692a8 100644
--- a/flink-core/src/main/java/org/apache/flink/api/common/io/compression/Bzip2InputStreamFactory.java
+++ b/flink-core/src/main/java/org/apache/flink/api/common/io/compression/Bzip2InputStreamFactory.java
@@ -15,26 +15,27 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
+
package org.apache.flink.api.common.io.compression;
import org.apache.flink.annotation.Internal;
+import org.apache.commons.compress.compressors.bzip2.BZip2CompressorInputStream;
+
import java.io.IOException;
import java.io.InputStream;
import java.util.Collection;
import java.util.Collections;
-import org.apache.commons.compress.compressors.bzip2.BZip2CompressorInputStream;
-
+/**
+ * Factory for Bzip2 decompressors.
+ */
@Internal
public class Bzip2InputStreamFactory implements InflaterInputStreamFactory<BZip2CompressorInputStream> {
- private static Bzip2InputStreamFactory INSTANCE = null;
+ private static final Bzip2InputStreamFactory INSTANCE = new Bzip2InputStreamFactory();
public static Bzip2InputStreamFactory getInstance() {
- if (INSTANCE == null) {
- INSTANCE = new Bzip2InputStreamFactory();
- }
return INSTANCE;
}
http://git-wip-us.apache.org/repos/asf/flink/blob/548e9ed5/flink-core/src/main/java/org/apache/flink/api/common/io/compression/DeflateInflaterInputStreamFactory.java
----------------------------------------------------------------------
diff --git a/flink-core/src/main/java/org/apache/flink/api/common/io/compression/DeflateInflaterInputStreamFactory.java b/flink-core/src/main/java/org/apache/flink/api/common/io/compression/DeflateInflaterInputStreamFactory.java
index b5051e6..33f7d51 100644
--- a/flink-core/src/main/java/org/apache/flink/api/common/io/compression/DeflateInflaterInputStreamFactory.java
+++ b/flink-core/src/main/java/org/apache/flink/api/common/io/compression/DeflateInflaterInputStreamFactory.java
@@ -15,6 +15,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
+
package org.apache.flink.api.common.io.compression;
import org.apache.flink.annotation.Internal;
@@ -31,12 +32,9 @@ import java.util.zip.InflaterInputStream;
@Internal
public class DeflateInflaterInputStreamFactory implements InflaterInputStreamFactory<InflaterInputStream> {
- private static DeflateInflaterInputStreamFactory INSTANCE = null;
+ private static final DeflateInflaterInputStreamFactory INSTANCE = new DeflateInflaterInputStreamFactory();
public static DeflateInflaterInputStreamFactory getInstance() {
- if (INSTANCE == null) {
- INSTANCE = new DeflateInflaterInputStreamFactory();
- }
return INSTANCE;
}
http://git-wip-us.apache.org/repos/asf/flink/blob/548e9ed5/flink-core/src/main/java/org/apache/flink/api/common/io/compression/GzipInflaterInputStreamFactory.java
----------------------------------------------------------------------
diff --git a/flink-core/src/main/java/org/apache/flink/api/common/io/compression/GzipInflaterInputStreamFactory.java b/flink-core/src/main/java/org/apache/flink/api/common/io/compression/GzipInflaterInputStreamFactory.java
index 478eb2d..335e365 100644
--- a/flink-core/src/main/java/org/apache/flink/api/common/io/compression/GzipInflaterInputStreamFactory.java
+++ b/flink-core/src/main/java/org/apache/flink/api/common/io/compression/GzipInflaterInputStreamFactory.java
@@ -15,6 +15,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
+
package org.apache.flink.api.common.io.compression;
import org.apache.flink.annotation.Internal;
@@ -31,14 +32,12 @@ import java.util.zip.GZIPInputStream;
@Internal
public class GzipInflaterInputStreamFactory implements InflaterInputStreamFactory<GZIPInputStream> {
- private static GzipInflaterInputStreamFactory INSTANCE = null;
+ private static final GzipInflaterInputStreamFactory INSTANCE = new GzipInflaterInputStreamFactory();
public static GzipInflaterInputStreamFactory getInstance() {
- if (INSTANCE == null) {
- INSTANCE = new GzipInflaterInputStreamFactory();
- }
return INSTANCE;
}
+
@Override
public GZIPInputStream create(InputStream in) throws IOException {
return new GZIPInputStream(in);
http://git-wip-us.apache.org/repos/asf/flink/blob/548e9ed5/flink-core/src/main/java/org/apache/flink/api/common/io/compression/XZInputStreamFactory.java
----------------------------------------------------------------------
diff --git a/flink-core/src/main/java/org/apache/flink/api/common/io/compression/XZInputStreamFactory.java b/flink-core/src/main/java/org/apache/flink/api/common/io/compression/XZInputStreamFactory.java
index c80de40..0802ab6 100644
--- a/flink-core/src/main/java/org/apache/flink/api/common/io/compression/XZInputStreamFactory.java
+++ b/flink-core/src/main/java/org/apache/flink/api/common/io/compression/XZInputStreamFactory.java
@@ -15,25 +15,27 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
+
package org.apache.flink.api.common.io.compression;
-import org.apache.commons.compress.compressors.xz.XZCompressorInputStream;
import org.apache.flink.annotation.Internal;
+import org.apache.commons.compress.compressors.xz.XZCompressorInputStream;
+
import java.io.IOException;
import java.io.InputStream;
import java.util.Collection;
import java.util.Collections;
+/**
+ * Factory for XZ decompressors.
+ */
@Internal
public class XZInputStreamFactory implements InflaterInputStreamFactory<XZCompressorInputStream> {
- private static XZInputStreamFactory INSTANCE = null;
+ private static final XZInputStreamFactory INSTANCE = new XZInputStreamFactory();
public static XZInputStreamFactory getInstance() {
- if (INSTANCE == null) {
- INSTANCE = new XZInputStreamFactory();
- }
return INSTANCE;
}