You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "David Jencks (JIRA)" <ji...@apache.org> on 2007/06/23 19:30:26 UTC
[jira] Created: (GERONIMO-3257) gbean dependencies should be
started after collection references are updated
gbean dependencies should be started after collection references are updated
----------------------------------------------------------------------------
Key: GERONIMO-3257
URL: https://issues.apache.org/jira/browse/GERONIMO-3257
Project: Geronimo
Issue Type: Bug
Security Level: public (Regular issues)
Components: kernel
Affects Versions: 2.0-M6
Reporter: David Jencks
Assignee: David Jencks
Fix For: 2.0-M7
Some excellent debugging by jgawor revealed that JettyFilterMapping was often getting started before all the servlets it depends on are started. This was causing filters to sometimes not get applied to the correct servlets.
JettyModuleBuilder is adding a dependency for each servlet gbean to the filter mapping gbean, so the filter mapping wont start until after all the servlets expected to be in the collection are started. However, the "dependency" notification is getting fired before the "add to reference collection" notification, so the collections of servlets is not always correct.
I think we can put some more ordering into the system so that all the reference collections are updated before dependencies are notified.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (GERONIMO-3257) gbean dependencies should be started
after collection references are updated
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks closed GERONIMO-3257.
----------------------------------
Resolution: Fixed
Seems to work... rev 550068.
> gbean dependencies should be started after collection references are updated
> ----------------------------------------------------------------------------
>
> Key: GERONIMO-3257
> URL: https://issues.apache.org/jira/browse/GERONIMO-3257
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: kernel
> Affects Versions: 2.0-M6
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: 2.0-M7
>
>
> Some excellent debugging by jgawor revealed that JettyFilterMapping was often getting started before all the servlets it depends on are started. This was causing filters to sometimes not get applied to the correct servlets.
> JettyModuleBuilder is adding a dependency for each servlet gbean to the filter mapping gbean, so the filter mapping wont start until after all the servlets expected to be in the collection are started. However, the "dependency" notification is getting fired before the "add to reference collection" notification, so the collections of servlets is not always correct.
> I think we can put some more ordering into the system so that all the reference collections are updated before dependencies are notified.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (GERONIMO-3257) gbean dependencies should be
started after collection references are updated
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks reopened GERONIMO-3257:
------------------------------------
It turns out that this is not foolproof. Starting the jetty webconsole sometimes results in starting a filter mapping before it's servlet has been added to the reference collection. Looking at the stack trace it looks like there are 2 or 3 levels of dependency notification going on and this sneaks around the ordering somehow. I think a more frutiful approach would be some kind of multivalued required dependency.
> gbean dependencies should be started after collection references are updated
> ----------------------------------------------------------------------------
>
> Key: GERONIMO-3257
> URL: https://issues.apache.org/jira/browse/GERONIMO-3257
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: kernel
> Affects Versions: 2.0-M6
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: 2.0-M7
>
>
> Some excellent debugging by jgawor revealed that JettyFilterMapping was often getting started before all the servlets it depends on are started. This was causing filters to sometimes not get applied to the correct servlets.
> JettyModuleBuilder is adding a dependency for each servlet gbean to the filter mapping gbean, so the filter mapping wont start until after all the servlets expected to be in the collection are started. However, the "dependency" notification is getting fired before the "add to reference collection" notification, so the collections of servlets is not always correct.
> I think we can put some more ordering into the system so that all the reference collections are updated before dependencies are notified.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-3257) gbean dependencies should be
started after collection references are updated
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks updated GERONIMO-3257:
-----------------------------------
Fix Version/s: (was: 2.0)
(was: Verification Required)
Wish List
Not going to happen by 2.0
> gbean dependencies should be started after collection references are updated
> ----------------------------------------------------------------------------
>
> Key: GERONIMO-3257
> URL: https://issues.apache.org/jira/browse/GERONIMO-3257
> Project: Geronimo
> Issue Type: Wish
> Security Level: public(Regular issues)
> Components: kernel
> Affects Versions: 2.0-M6
> Reporter: David Jencks
> Fix For: Wish List
>
>
> Some excellent debugging by jgawor revealed that JettyFilterMapping was often getting started before all the servlets it depends on are started. This was causing filters to sometimes not get applied to the correct servlets.
> JettyModuleBuilder is adding a dependency for each servlet gbean to the filter mapping gbean, so the filter mapping wont start until after all the servlets expected to be in the collection are started. However, the "dependency" notification is getting fired before the "add to reference collection" notification, so the collections of servlets is not always correct.
> I think we can put some more ordering into the system so that all the reference collections are updated before dependencies are notified.
> --- After the obvious fix didn't work I think a whole new reference collection might be needed to really fix this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-3257) gbean dependencies should be
started after collection references are updated
Posted by "Prasad Kashyap (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Kashyap updated GERONIMO-3257:
-------------------------------------
Fix Version/s: (was: 2.0-M7)
Verification Required
2.0
> gbean dependencies should be started after collection references are updated
> ----------------------------------------------------------------------------
>
> Key: GERONIMO-3257
> URL: https://issues.apache.org/jira/browse/GERONIMO-3257
> Project: Geronimo
> Issue Type: Wish
> Security Level: public(Regular issues)
> Components: kernel
> Affects Versions: 2.0-M6
> Reporter: David Jencks
> Fix For: 2.0, Verification Required
>
>
> Some excellent debugging by jgawor revealed that JettyFilterMapping was often getting started before all the servlets it depends on are started. This was causing filters to sometimes not get applied to the correct servlets.
> JettyModuleBuilder is adding a dependency for each servlet gbean to the filter mapping gbean, so the filter mapping wont start until after all the servlets expected to be in the collection are started. However, the "dependency" notification is getting fired before the "add to reference collection" notification, so the collections of servlets is not always correct.
> I think we can put some more ordering into the system so that all the reference collections are updated before dependencies are notified.
> --- After the obvious fix didn't work I think a whole new reference collection might be needed to really fix this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-3257) gbean dependencies should be
started after collection references are updated
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks updated GERONIMO-3257:
-----------------------------------
Description:
Some excellent debugging by jgawor revealed that JettyFilterMapping was often getting started before all the servlets it depends on are started. This was causing filters to sometimes not get applied to the correct servlets.
JettyModuleBuilder is adding a dependency for each servlet gbean to the filter mapping gbean, so the filter mapping wont start until after all the servlets expected to be in the collection are started. However, the "dependency" notification is getting fired before the "add to reference collection" notification, so the collections of servlets is not always correct.
I think we can put some more ordering into the system so that all the reference collections are updated before dependencies are notified.
--- After the obvious fix didn't work I think a whole new reference collection might be needed to really fix this.
was:
Some excellent debugging by jgawor revealed that JettyFilterMapping was often getting started before all the servlets it depends on are started. This was causing filters to sometimes not get applied to the correct servlets.
JettyModuleBuilder is adding a dependency for each servlet gbean to the filter mapping gbean, so the filter mapping wont start until after all the servlets expected to be in the collection are started. However, the "dependency" notification is getting fired before the "add to reference collection" notification, so the collections of servlets is not always correct.
I think we can put some more ordering into the system so that all the reference collections are updated before dependencies are notified.
Assignee: (was: David Jencks)
Issue Type: Wish (was: Bug)
> gbean dependencies should be started after collection references are updated
> ----------------------------------------------------------------------------
>
> Key: GERONIMO-3257
> URL: https://issues.apache.org/jira/browse/GERONIMO-3257
> Project: Geronimo
> Issue Type: Wish
> Security Level: public(Regular issues)
> Components: kernel
> Affects Versions: 2.0-M6
> Reporter: David Jencks
> Fix For: 2.0-M7
>
>
> Some excellent debugging by jgawor revealed that JettyFilterMapping was often getting started before all the servlets it depends on are started. This was causing filters to sometimes not get applied to the correct servlets.
> JettyModuleBuilder is adding a dependency for each servlet gbean to the filter mapping gbean, so the filter mapping wont start until after all the servlets expected to be in the collection are started. However, the "dependency" notification is getting fired before the "add to reference collection" notification, so the collections of servlets is not always correct.
> I think we can put some more ordering into the system so that all the reference collections are updated before dependencies are notified.
> --- After the obvious fix didn't work I think a whole new reference collection might be needed to really fix this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.