You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by jihoonson <gi...@git.apache.org> on 2015/09/12 18:31:14 UTC
[GitHub] tajo pull request: TAJO-1845: Enforcers in the master plan should ...
GitHub user jihoonson opened a pull request:
https://github.com/apache/tajo/pull/757
TAJO-1845: Enforcers in the master plan should be printed in a fixed order
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jihoonson/tajo-2 TAJO-1845
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/757.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #757
----
commit 8cbfc640b843290d274bbc5f52215e8124023b73
Author: Jihoon Son <ji...@apache.org>
Date: 2015-09-12T16:30:38Z
TAJO-1845
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1845: Enforcers in the master plan should ...
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/757#issuecomment-139845435
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1845: Enforcers in the master plan should ...
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on a diff in the pull request:
https://github.com/apache/tajo/pull/757#discussion_r39344654
--- Diff: tajo-core-tests/src/test/resources/results/TestInnerJoinWithSubQuery/testComplexJoinCondition5.result ---
@@ -5,25 +5,3 @@ n_nationkey,name1,name2
2,BRAZ,BRAZ
3,CANA,CANA
4,EGYP,EGYP
-5,ETHI,ETHI
--- End diff --
Oops! the table is small_nation. I understood
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1845: Enforcers in the master plan should ...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/757#issuecomment-139845648
Thank you for the quick review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1845: Enforcers in the master plan should ...
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on a diff in the pull request:
https://github.com/apache/tajo/pull/757#discussion_r39344502
--- Diff: tajo-core-tests/src/test/resources/results/TestInnerJoinWithSubQuery/testComplexJoinCondition5.result ---
@@ -5,25 +5,3 @@ n_nationkey,name1,name2
2,BRAZ,BRAZ
3,CANA,CANA
4,EGYP,EGYP
-5,ETHI,ETHI
--- End diff --
@jihoonson
Is this correct result ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1845: Enforcers in the master plan should ...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/757#discussion_r39344554
--- Diff: tajo-core-tests/src/test/resources/results/TestInnerJoinWithSubQuery/testComplexJoinCondition5.result ---
@@ -5,25 +5,3 @@ n_nationkey,name1,name2
2,BRAZ,BRAZ
3,CANA,CANA
4,EGYP,EGYP
-5,ETHI,ETHI
--- End diff --
Yes, because I changed the query. The original query performs the self-join on ```nation```, which makes the query plan non-deterministic. So, I changed it to the join of ```nation``` and ```small_nation``` which is derived from the ```nation``` table.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1845: Enforcers in the master plan should ...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/757#issuecomment-139798993
I've changed some test queries for more deterministic test result.
In these queries, a single table is used twice for join, that is self join. Since the join tables have the same volume, broadcast table can be changed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1845: Enforcers in the master plan should ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/757
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---