You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by John Kordich via Review Board <no...@reviews.apache.org> on 2018/05/14 22:42:01 UTC
Review Request 67118: Added bzip2, libarchive, and xz tarballs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67118/
-----------------------------------------------------------
Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
Bugs: MESOS-8064
https://issues.apache.org/jira/browse/MESOS-8064
Repository: mesos
Description
-------
Added bzip2, libarchive, and xz tarballs.
Diffs
-----
3rdparty/bzip2-1.0.6.tar.gz PRE-CREATION
3rdparty/libarchive-3.3.2.tar.gz PRE-CREATION
3rdparty/xz-5.2.3.tar.gz PRE-CREATION
Diff: https://reviews.apache.org/r/67118/diff/1/
Testing
-------
This is just the tarballs for each added archive, no testing required.
Thanks,
John Kordich
Re: Review Request 67118: Added bzip2, libarchive, and xz tarballs.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67118/#review204072
-----------------------------------------------------------
Ship it!
The xz.README could use a little bit more explaination. I'll add some more before committing:
```
The xz archive is modified to contain only the minimal files required
to build on Windows. The original archive contains several files with
licenses that are incompatible with with the Apache License,
and therefore, cannot be bundled into the project.
```
- Joseph Wu
On May 24, 2018, 7:08 p.m., John Kordich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67118/
> -----------------------------------------------------------
>
> (Updated May 24, 2018, 7:08 p.m.)
>
>
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
>
>
> Bugs: MESOS-8064
> https://issues.apache.org/jira/browse/MESOS-8064
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added bzip2, libarchive, and xz tarballs.
>
>
> Diffs
> -----
>
> 3rdparty/bzip2-1.0.6.tar.gz PRE-CREATION
> 3rdparty/libarchive-3.3.2.tar.gz PRE-CREATION
> 3rdparty/xz-5.2.3-modified.tar.gz PRE-CREATION
> 3rdparty/xz.README.txt PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/67118/diff/2/
>
>
> Testing
> -------
>
> This is just the tarballs for each added archive, no testing required.
>
>
> Thanks,
>
> John Kordich
>
>
Re: Review Request 67118: Added bzip2, libarchive, and xz tarballs.
Posted by John Kordich via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67118/
-----------------------------------------------------------
(Updated May 25, 2018, 2:08 a.m.)
Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
Changes
-------
Removed files from the original xz archive such that it does not contain source files with incompatible licenses.
Bugs: MESOS-8064
https://issues.apache.org/jira/browse/MESOS-8064
Repository: mesos
Description
-------
Added bzip2, libarchive, and xz tarballs.
Diffs (updated)
-----
3rdparty/bzip2-1.0.6.tar.gz PRE-CREATION
3rdparty/libarchive-3.3.2.tar.gz PRE-CREATION
3rdparty/xz-5.2.3-modified.tar.gz PRE-CREATION
3rdparty/xz.README.txt PRE-CREATION
Diff: https://reviews.apache.org/r/67118/diff/2/
Changes: https://reviews.apache.org/r/67118/diff/1-2/
Testing
-------
This is just the tarballs for each added archive, no testing required.
Thanks,
John Kordich
Re: Review Request 67118: Added bzip2, libarchive, and xz tarballs.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67118/#review203601
-----------------------------------------------------------
Jie brought it up that the `xz` archive contains GNU GPL licensed files, which should not be included in Apache projects:
https://www.apache.org/legal/resolved.html#category-x
However, the problematic files are a subset of the actual sources. We basically don't use any of the licensed files (as far as I can tell), which include some scripts under `src/scripts` and some of the build files.
I've opened an issue to see what we need to do prior to including XZ: https://issues.apache.org/jira/browse/LEGAL-384
(bzip2 and libarchive are BSD licensed, which is allowed.)
- Joseph Wu
On May 14, 2018, 3:42 p.m., John Kordich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67118/
> -----------------------------------------------------------
>
> (Updated May 14, 2018, 3:42 p.m.)
>
>
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
>
>
> Bugs: MESOS-8064
> https://issues.apache.org/jira/browse/MESOS-8064
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added bzip2, libarchive, and xz tarballs.
>
>
> Diffs
> -----
>
> 3rdparty/bzip2-1.0.6.tar.gz PRE-CREATION
> 3rdparty/libarchive-3.3.2.tar.gz PRE-CREATION
> 3rdparty/xz-5.2.3.tar.gz PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/67118/diff/1/
>
>
> Testing
> -------
>
> This is just the tarballs for each added archive, no testing required.
>
>
> Thanks,
>
> John Kordich
>
>