You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Jargon9 (via GitHub)" <gi...@apache.org> on 2023/03/05 08:05:56 UTC
[GitHub] [rocketmq-streams] Jargon9 opened a new pull request, #276: [ISSUE #272]Support subscribe topic from first
Jargon9 opened a new pull request, #276:
URL: https://github.com/apache/rocketmq-streams/pull/276
Hi teams, I have completed support subscribe topic from first. Here is the example :
Could you please review the code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] Jargon9 commented on pull request #276: [ISSUE #272]Support subscribe topic from first
Posted by "Jargon9 (via GitHub)" <gi...@apache.org>.
Jargon9 commented on PR #276:
URL: https://github.com/apache/rocketmq-streams/pull/276#issuecomment-1554031465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] Jargon9 commented on pull request #276: [ISSUE #272]Support subscribe topic from first
Posted by "Jargon9 (via GitHub)" <gi...@apache.org>.
Jargon9 commented on PR #276:
URL: https://github.com/apache/rocketmq-streams/pull/276#issuecomment-1547848575
@ni-ze I have fix it. Could you please review the code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] Jargon9 commented on pull request #276: [ISSUE #272]Support subscribe topic from first
Posted by "Jargon9 (via GitHub)" <gi...@apache.org>.
Jargon9 commented on PR #276:
URL: https://github.com/apache/rocketmq-streams/pull/276#issuecomment-1554029552
@ni-ze Got it, I have filtered out shuffle topic ( end with -shuffleTopic) . Is it necessary to filter the state topic (end with -stateTopic)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] Jargon9 commented on pull request #276: [ISSUE #272]Support subscribe topic from first
Posted by "Jargon9 (via GitHub)" <gi...@apache.org>.
Jargon9 commented on PR #276:
URL: https://github.com/apache/rocketmq-streams/pull/276#issuecomment-1606121107
@ni-ze Got it, thanks. I will handle this in this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] ni-ze closed pull request #276: [ISSUE #272]Support subscribe topic from first
Posted by "ni-ze (via GitHub)" <gi...@apache.org>.
ni-ze closed pull request #276: [ISSUE #272]Support subscribe topic from first
URL: https://github.com/apache/rocketmq-streams/pull/276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] Jargon9 commented on pull request #276: [ISSUE #272]Support subscribe topic from first
Posted by "Jargon9 (via GitHub)" <gi...@apache.org>.
Jargon9 commented on PR #276:
URL: https://github.com/apache/rocketmq-streams/pull/276#issuecomment-1518554613
It's a bit strange that I didn't see this comment in the file change and conversation. Thank you very much for pointing it out and I will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] ni-ze commented on pull request #276: [ISSUE #272]Support subscribe topic from first
Posted by "ni-ze (via GitHub)" <gi...@apache.org>.
ni-ze commented on PR #276:
URL: https://github.com/apache/rocketmq-streams/pull/276#issuecomment-1518527903
Maybe you can find it in Files changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] ni-ze closed pull request #276: [ISSUE #272]Support subscribe topic from first
Posted by "ni-ze (via GitHub)" <gi...@apache.org>.
ni-ze closed pull request #276: [ISSUE #272]Support subscribe topic from first
URL: https://github.com/apache/rocketmq-streams/pull/276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] ni-ze commented on pull request #276: [ISSUE #272]Support subscribe topic from first
Posted by "ni-ze (via GitHub)" <gi...@apache.org>.
ni-ze commented on PR #276:
URL: https://github.com/apache/rocketmq-streams/pull/276#issuecomment-1627010091
@Jargon9 Use tool DefaultMQAdminExt to reset offset before start consumer maybe works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] ni-ze commented on pull request #276: [ISSUE #272]Support subscribe topic from first
Posted by "ni-ze (via GitHub)" <gi...@apache.org>.
ni-ze commented on PR #276:
URL: https://github.com/apache/rocketmq-streams/pull/276#issuecomment-1517180418
@Jargon9 Before resolve the problem, I will close this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] ni-ze commented on pull request #276: [ISSUE #272]Support subscribe topic from first
Posted by "ni-ze (via GitHub)" <gi...@apache.org>.
ni-ze commented on PR #276:
URL: https://github.com/apache/rocketmq-streams/pull/276#issuecomment-1585619825
@Jargon9 It does need seek to the beginning of use topic. But we can reset the offset after the rebalance, like the recover the state of shuffle topic. The details can be find in class MessageQueueListenerWrapper, where the state is recovered after rebalance. Reset user topic offset can be invoked here, I think. Sorry for late to reply you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] Jargon9 commented on pull request #276: [ISSUE #272]Support subscribe topic from first
Posted by "Jargon9 (via GitHub)" <gi...@apache.org>.
Jargon9 commented on PR #276:
URL: https://github.com/apache/rocketmq-streams/pull/276#issuecomment-1517699226
> @Jargon9 Before resolve the problem, I will close this pr.
@ni-ze Dear Sir Ni, I did not see your code comment. What is the problem you mentioned?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] Jargon9 commented on pull request #276: [ISSUE #272]Support subscribe topic from first
Posted by "Jargon9 (via GitHub)" <gi...@apache.org>.
Jargon9 commented on PR #276:
URL: https://github.com/apache/rocketmq-streams/pull/276#issuecomment-1552935694
@ni-ze Dear Mr. Ni, if there are any comments, please let me know in the comments in case I receive no message as before. Thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] ni-ze commented on pull request #276: [ISSUE #272]Support subscribe topic from first
Posted by "ni-ze (via GitHub)" <gi...@apache.org>.
ni-ze commented on PR #276:
URL: https://github.com/apache/rocketmq-streams/pull/276#issuecomment-1553879754
@Jargon9 the unionConsumer in PlanetaryEngine is shared by two kind of topics, the source topic and shuffle topic. Source topic is up to user to decide consume from the last or the earliest. But the shuffle topic is consumed from the last always.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] Jargon9 commented on pull request #276: [ISSUE #272]Support subscribe topic from first
Posted by "Jargon9 (via GitHub)" <gi...@apache.org>.
Jargon9 commented on PR #276:
URL: https://github.com/apache/rocketmq-streams/pull/276#issuecomment-1573192567
@ni-ze Dear Mr. Ni, If there are any further issues, could you please help point them out？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] ni-ze commented on pull request #276: [ISSUE #272]Support subscribe topic from first
Posted by "ni-ze (via GitHub)" <gi...@apache.org>.
ni-ze commented on PR #276:
URL: https://github.com/apache/rocketmq-streams/pull/276#issuecomment-1627014319
Can I have you WeChat？ It finish this as fast as possible, it really have a while from begin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] Jargon9 commented on pull request #276: [ISSUE #272]Support subscribe topic from first
Posted by "Jargon9 (via GitHub)" <gi...@apache.org>.
Jargon9 commented on PR #276:
URL: https://github.com/apache/rocketmq-streams/pull/276#issuecomment-1616709358
@ni-ze Dear sir, I have noticed a problem where if I place resetOffset before originListener. messageQueueChanged, there may be an error （still in rebalance）, while after placing it in originListener. messageQueueChanged, there may be an issue where consumption has already started. Do you have any good suggestions for this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] Jargon9 commented on pull request #276: [ISSUE #272]Support subscribe topic from first
Posted by "Jargon9 (via GitHub)" <gi...@apache.org>.
Jargon9 commented on PR #276:
URL: https://github.com/apache/rocketmq-streams/pull/276#issuecomment-1616709552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] ni-ze merged pull request #276: [ISSUE #272]Support subscribe topic from first
Posted by "ni-ze (via GitHub)" <gi...@apache.org>.
ni-ze merged PR #276:
URL: https://github.com/apache/rocketmq-streams/pull/276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] Jargon9 commented on pull request #276: [ISSUE #272]Support subscribe topic from first
Posted by "Jargon9 (via GitHub)" <gi...@apache.org>.
Jargon9 commented on PR #276:
URL: https://github.com/apache/rocketmq-streams/pull/276#issuecomment-1534877298
Sorry, there are important things to deal with during the May Day holiday, which has delayed the progress. I will fix it in the next two weeks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] ni-ze commented on pull request #276: [ISSUE #272]Support subscribe topic from first
Posted by "ni-ze (via GitHub)" <gi...@apache.org>.
ni-ze commented on PR #276:
URL: https://github.com/apache/rocketmq-streams/pull/276#issuecomment-1534045330
@Jargon9 can you fix this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org